Clean up the OTIO reader annotation #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloisebrosseau
requested review from
rogernelson,
cedrik-fuoco-adsk and
bernie-laberge
eloisebrosseau
force-pushed
the
live-review-annotation
branch
from
2fc82c9 to
1b08cf5
Compare
eloisebrosseau
force-pushed
the
live-review-annotation
branch
from
1b08cf5 to
1dc7645
Compare
bernie-laberge
approved these changes
Dec 2, 2024
rogernelson
reviewed
Dec 11, 2024
rogernelson
approved these changes
Dec 11, 2024
eloisebrosseau
force-pushed
the
live-review-annotation
branch
from
1dc7645 to
1866e5c
Compare
Signed-off-by: Éloïse Brosseau <[email protected]>
Signed-off-by: Éloïse Brosseau <[email protected]>
eloisebrosseau
force-pushed
the
live-review-annotation
branch
from
1866e5c to
2e2c807
Compare
eloisebrosseau
changed the title
eloisebrosseau
merged commit bc93220
into
AcademySoftwareFoundation:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the OTIO reader annotation
This PR aims to clean up a bit the code related to the OTIO reader for annotations in Live Review.
Question
I see that some files for other hooks and schemas are in camel case instead of snake case. Does anyone knows if there is a reason? Is everyone ok with me renaming the files inside
otio_readerto use snake case instead?