Support negative values on nthreads
#4534
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes
nthreads
accept negative numbers to meanm_pool->size()
+nthreads
. I.e. on a16
core machine specifyingnthreads
as-2
would make OIIO use14
cores.If
m_pool->size()
<-nthreads
the result is clamped at1
. I.e. a single thread would be used.On that note: the original
resolve()
does not have a check for the case wherem_maxthreads
>m_pool->size()
and should possibly be clamped to the latter, if so. I kept it that way. Is that intended/a feature or an oversight?Tests
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.