perf: oiiotool --line --text --point --box speedups #4518
Conversation
|
Comments? |
|
Can somebody review this? I'm trying to get out of the habit of merging my own patches without positive proof that somebody else's eyes have been on it. |
I can :) |
|
I'm less worried about the testing -- the CI ought to vouch for the correctness of the result -- but more just looking over the code to see if it seems reasonable. I just don't like the optics of merging my own PR without so much as a single comment from anybody else. We do it too often, but it's something that any healthy project should only do in dire emergencies. |
lgritz
added
image processing
These commands, which are intended to alter the top image on the stack, were each allocating and copying an image unnecessarily for each operation. By changing the implementation to the right calls that know it doesn't need to make a copy (already a feature I'd implemented in the OiiotoolOp helper class) greatly speeds them up. Signed-off-by: Larry Gritz <[email protected]>
Signed-off-by: Larry Gritz <[email protected]>
Signed-off-by: Larry Gritz <[email protected]>
…oundation#4518) These commands, which are intended to alter the top image on the stack, were each allocating and copying an image unnecessarily for each operation. By changing the implementation to the right calls that know it doesn't need to make a copy (already a feature I'd implemented in the OiiotoolOp helper class) greatly speeds them up. --------- Signed-off-by: Larry Gritz <[email protected]>
These commands, which are intended to alter the top image on the stack, were each allocating and copying an image unnecessarily for each operation. By changing the implementation to the right calls that know it doesn't need to make a copy (already a feature I'd implemented in the OiiotoolOp helper class) greatly speeds them up.