Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Conversion of ImageInput docs to tests for the scanlines examples #4444

Merged

Conversation

ziadkhouri
Copy link
Contributor

@ziadkhouri ziadkhouri commented Sep 26, 2024

Convert scanline C++ and Python examples from the "imageinput" chapter into tests within the "docs-examples" testsuites (#3992).

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable. (Check if there is no
    need to update the documentation, for example if this is a bug fix that
    doesn't change the API.)
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • If I added or modified a C++ API call, I have also amended the
    corresponding Python bindings (and if altering ImageBufAlgo functions, also
    exposed the new functionality as oiiotool options).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

Copy link

linux-foundation-easycla bot commented Sep 26, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Signed-off-by: Ziad Khouri <[email protected]>
Signed-off-by: Ziad Khouri <[email protected]>
Signed-off-by: Ziad Khouri <[email protected]>

Signed-off-by: Ziad Khouri <[email protected]>
Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks correct and passes tests! (Except for some known failures unrelated to this PR.)

Congratulations!

@lgritz lgritz merged commit e5ad995 into AcademySoftwareFoundation:main Sep 27, 2024
25 of 27 checks passed
@lgritz lgritz added Dev Days ASWF Dev Days suitable project devdays24 Dev Days 2024 build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration. docs Documentation labels Sep 27, 2024
@lgritz lgritz changed the title docs:imageinput-scanlines docs: Conversion of ImageInput docs to tests for the scanlines examples Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build / testing / port / CI Affecting the build system, tests, platform support, porting, or continuous integration. Dev Days ASWF Dev Days suitable project devdays24 Dev Days 2024 docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants