-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: remove redundant ImageSpec from ImageCache (issue #4436) #4442
api: remove redundant ImageSpec from ImageCache (issue #4436) #4442
Conversation
Other than the comment I made about elaborating the description a bit, this is all looking great to me. We talked in a different channel about adding back some very minimal inline methods to keep back compatibility for now, so I know that's still on its way, but if that ends up straightforward, we should be able to merge this without any trouble. Then the API will be nailed down and you can do the further changes to the internals without any additional compatibility breaks during our upcoming beta period. |
I've added the backwards compatible methods for ImageCache |
…ion#4436 Signed-off-by: Basile Fraboni <[email protected]>
Signed-off-by: Basile Fraboni <[email protected]>
Signed-off-by: Basile Fraboni <[email protected]>
Signed-off-by: Basile Fraboni <[email protected]>
Signed-off-by: Basile Fraboni <[email protected]>
e0a70c2
to
90a297e
Compare
…) unit tests Signed-off-by: Basile Fraboni <[email protected]>
I've just rebased the PR and added the unit tests for |
Signed-off-by: Basile Fraboni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I suggested two changes to docs -- just inserting a blank line to be sure it understands the parameter command. I will add those for you by simply accepting the suggestions, then merge.
Thanks, this is great. Looking forward to the eventual change to the internal implementation, but this at least gets the new API locked into place.
Slight fix to comment formatting Signed-off-by: Larry Gritz <[email protected]>
Slight fix to comment formatting Signed-off-by: Larry Gritz <[email protected]>
14be11a
into
AcademySoftwareFoundation:main
Description
First draft of frontend changes for issue #4436.
Checklist:
imagespec
,get_imagespec
API calls in ImageCache, ImageCacheImpl, TextureSystem and all calls.get_cache_dimensions
to access cache internal mip level dimensionsget_cache_dimensions
unit tests once we validate the new version