-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Convert more examples within the imagebufalgo chapter. #4039
Conversation
CI errors are occurring when comparing resulting images with expected outcomes for the
I feel it could be due to rounding errors, but I'm not entirely sure 🧐 |
cefbcb4
to
7a14d0d
Compare
After analyzing the "dumpdata" produced on different CI jobs for the
Updating the test to use TIFF input and output instead of EXR solved the problem, but it doesn't solve it for the Besides, both tests using TIFF and a few other tests are failing on the CI-Mac-ARM job:
So, I feel like comparing image hashes for these specific tests is probably not a reasonable testing strategy, as multiple parameters likely play a role in the outcome. It would be interesting to get down the rabbit hole to understand what produces these differences (whether it comes from the OIIO codebase, a third-party dependency, or the platform?). But, for now, I will simply adjust these tests to move on with this issue. |
The remaining CI errors don't seem to be related to this update:
|
The tiff-misc failures are new, happening on several branches, none of which have changed the tiff code recently. I think something updated on the CI machines, new TIFF library or something like that. I will chase it down separately when I'm feeling better. I think you're seeing some numerical differences. No need to switch to TIFF -- I don't see why that would fix it. But the way we usually deal with this is just to check in a second test output to the ref directory (call it out-alt.txt or something like that). The way the tests work is that they'll pass as long as it matches any output in ref, there can be multiple. |
I'm happy to clean it all up in a few days, you don't need to chase down this numerical nonsense if you don't want to. It's not a necessary rabbit hole. |
I actually removed the extra command to write output images to be compared for the tests with numerical differences. It is still being tested, but there is no longer any hash comparison so it wouldn't fail in any CI jobs. Let me know if this is good enough! |
Convert C++ and Python examples from the "Image transformations and data movement" section of the "imagebufalgo" chapter into tests within the "docs-examples" testsuites (AcademySoftwareFoundation#3992). Update 'oiiotool' tabs to use a simple 'tab' instead of 'code-tab' to prevent synchronized tab selection, which is inconsistent with the other tabs using the 'literalinclude' directive. Note: image hashes comparison can not be used for testing 'rotate', 'resample', 'resize', 'fit', and 'warp', as it produces minor differences linked on the testing environment. Signed-off-by: Jeremy Retailleau <[email protected]>
…op jumping Signed-off-by: Larry Gritz <[email protected]>
I'm not sure how this fell into the cracks for so long, but I took the liberty of rebasing on top of the current master, making sure all your tests actually output an image and are checked, and some other minor fixups. If I can get this to pass CI, I will at long last merge it! |
The one CI failure on the "bleeding edge" test does not appear to be at all related to this patch, so I'm merging. Thanks, @buddly27, and apologies for how long this took. |
856dc6f
into
AcademySoftwareFoundation:master
…SoftwareFoundation#4039) Convert C++ and Python examples from the "Image transformations and data movement" section of the "imagebufalgo" chapter into tests within the "docs-examples" testsuites (related to issue AcademySoftwareFoundation#3992). Update 'oiiotool' tabs to use a simple 'tab' instead of 'code-tab' to prevent synchronized tab selection, which is inconsistent with the other tabs using the 'literalinclude' directive. --------- Signed-off-by: Jeremy Retailleau <[email protected]> Signed-off-by: Zach Lewis <[email protected]>
Description
Convert C++ and Python examples from the "Image transformations and data movement" section of the "imagebufalgo" chapter into tests within the "docs-examples" testsuites (#3992).
Update 'oiiotool' tabs to use a simple 'tab' instead of 'code-tab' to prevent synchronized tab selection, which is inconsistent with the other tabs using the 'literalinclude' directive.
Checklist:
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.