[rqd] Add frame recovery logic for docker mode #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever rqd restarts it loses track of all the frames launched by it that haven't finished. This change adds a new configurable option to backup frame states to a file, that is used to recover the frame cache state and try to re-bind to the running frames. This first version only works on docker mode
Signed-off-by: Diego Tavares <[email protected]>
DiegoTavares
force-pushed
the
recover_on_restart_rqd
branch
3 times, most recently
from
71ae0f9 to
5fa31c7
Compare
DiegoTavares
force-pushed
the
recover_on_restart_rqd
branch
2 times, most recently
from
bda928c to
b40527b
Compare
DiegoTavares
force-pushed
the
recover_on_restart_rqd
branch
from
b40527b to
3b24dd1
Compare
DiegoTavares
force-pushed
the
recover_on_restart_rqd
branch
2 times, most recently
from
18bf372 to
4d87bf6
Compare
DiegoTavares
force-pushed
the
recover_on_restart_rqd
branch
from
4d87bf6 to
bdbc360
Compare
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
| @@ -921,7 +990,7 @@ def runLinux(self): | |||
| finally: | |||
| rqd.rqutil.permissionsLow() | |||
|
|
|||
| frameInfo.pid = frameInfo.forkedCommand.pid | |||
| frameInfo.pid = runFrame.pid = frameInfo.forkedCommand.pid | |||
There was a problem hiding this comment.
Double-check this double assignment and the other similar double assignments in the code.
frameInfo.pid = runFrame.pid = frameInfo.forkedCommand.pid| if time_till_next > (2 * rqd.rqconstants.RQD_MIN_PING_INTERVAL_SEC): | ||
| self.rqCore.onIntervalThread.cancel() | ||
| self.rqCore.onInterval(rqd.rqconstants.RQD_MIN_PING_INTERVAL_SEC) | ||
| # Atatch to the job and follow the logs |
There was a problem hiding this comment.
Fix comment:
Attach to the job and follow the logs
| @@ -967,5 +1065,7 @@ def test_runDarwin(self, getTempDirMock, permsUser, timeMock, popenMock): | |||
| ) | |||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Remove extra 2 lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever rqd restarts it loses track of all the frames launched by it that haven't finished. This change adds a new configurable option to backup frame states to a file, that is used to recover the frame cache state and try to re-bind to the running frames.
This first version only works on docker mode