[cuebot] Fix queries find_jobs_by_show #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ramonfigueiredo
commented
Feb 14, 2024
ramonfigueiredo
commented
- Fix the where clause in the find_jobs_by_show queries (FIND_JOBS_BY_SHOW_PRIORITY_MODE and FIND_JOBS_BY_SHOW_BALANCED_MODE)
- Remove duplicate PK check "job_resource.pk_job = job.pk_job" that is the same as "job.pk_job = job_resource.pk_job"
- Fix the where clause in the find_jobs_by_show queries (FIND_JOBS_BY_SHOW_PRIORITY_MODE and FIND_JOBS_BY_SHOW_BALANCED_MODE) - Remove duplicate PK check "job_resource.pk_job = job.pk_job" that is the same as "job.pk_job = job_resource.pk_job"
ramonfigueiredo
requested review from
bcipriano,
gregdenton,
jrray,
smith1511,
larsbijl,
DiegoTavares,
IdrisMiles and
splhack
as code owners
|
By removing the extra PK check the find_jobs_by_show becomes a little bit faster. This is important when OpenCue is dealing with a huge number of jobs, making it faster. |
bcipriano
approved these changes
Feb 15, 2024
|
Hi @bcipriano Thanks for your review and approval. I don't have the right to merge yet! |
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
carlosfelgarcia
pushed a commit
to carlosfelgarcia/OpenCue
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.