Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cuesubmit browse widget #1281

Conversation

KernAttila
Copy link
Contributor

Link the Issue(s) this Pull Request is related to.
#1279
#1271

Summarize your change.
This PR adds an optional Browse button to CueLabelLineEdit
You can enable it with setFolderBrowsable() or setFileBrowsable()
This function accepts optional file filters.

Applied those features to Maya, Nuke and Blender widgets
(Do we need additional file filters for those ?)

Screenshots.
File browser with filters:
image

Folder Browser:
image

@DiegoTavares
Copy link
Collaborator

This branch unfortunately got caught in conflicts. @KernAttila would you be willing to fix the conflicts and push another commit. I'll review and merge right away

@lithorus
Copy link
Contributor

Have merged #1281 #1282 #1283 #1284 into this branch (and fixed conflicts and a few missing bugs) :

https://github.com/lithorus/OpenCue/tree/pr/1281

Should I just create a new PR for the collected PR's?

@ramonfigueiredo
Copy link
Collaborator

ramonfigueiredo commented Jul 17, 2024

Have merged #1281 #1282 #1283 #1284 into this branch (and fixed conflicts and a few missing bugs) :

https://github.com/lithorus/OpenCue/tree/pr/1281

Should I just create a new PR for the collected PR's?

No problem, @lithorus. Thanks!

Once your new PR is merged into the master branch, please make sure to comment on each of @KernAttila's PRs (#1281, #1282, #1283, #1284) to inform @KernAttila that the conflicts have been resolved. Include the link to your new PR in each comment. This will ensure @KernAttila is aware, and we can then cancel his PRs.

@KernAttila, please note that your contributions to the OpenCue project will be credited to your GitHub account since @lithorus has merged your code into his new branch.

@KernAttila
Copy link
Contributor Author

@lithorus thanks for doing this, I couldn't find time to get back to those PRs recently. I'm glad it finally made it to the main branch :) I'll close those PRs.
Except #1284 that was not included. It is ready now that the 3 previous ones where merged.
Out of curiosity, have you had a chance to use the config file from this PR ?
@ramonfigueiredo thanks for the info, glad to be part of the contributor list ;)

@KernAttila
Copy link
Contributor Author

This was merged by @lithorus on #1425, closing this one.

@KernAttila KernAttila closed this Jul 25, 2024
@lithorus
Copy link
Contributor

lithorus commented Jul 25, 2024

@lithorus thanks for doing this, I couldn't find time to get back to those PRs recently. I'm glad it finally made it to the main branch :) I'll close those PRs. Except #1284 that was not included. It is ready now that the 3 previous ones where merged. Out of curiosity, have you had a chance to use the config file from this PR ? @ramonfigueiredo thanks for the info, glad to be part of the contributor list ;)

Hmm.. I was fairly sure that it was included. I remember doing some of the tests mentioned in the PR. Will have to double-check.
Edit:
You're right, I didn't include it. Do you want me to create a new PR and merge in there?

@KernAttila
Copy link
Contributor Author

No problem, well it seems to fail on CLA only, I'll check my history and amend the bad commits.
Let's keep in touch about that, I'll try to have it done for next week.
If I can't, we'll check for making a new PR :)

@ramonfigueiredo
Copy link
Collaborator

No problem, well it seems to fail on CLA only, I'll check my history and amend the bad commits. Let's keep in touch about that, I'll try to have it done for next week. If I can't, we'll check for making a new PR :)

Thanks @lithorus and @KernAttila !

@KernAttila KernAttila deleted the cuesubmit-browse-widget branch August 21, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants