-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cuesubmit browse widget #1281
Cuesubmit browse widget #1281
Conversation
…esult on the calling widget
…that feeds the lineEdit widget with browse result.
This branch unfortunately got caught in conflicts. @KernAttila would you be willing to fix the conflicts and push another commit. I'll review and merge right away |
Have merged #1281 #1282 #1283 #1284 into this branch (and fixed conflicts and a few missing bugs) : https://github.com/lithorus/OpenCue/tree/pr/1281 Should I just create a new PR for the collected PR's? |
No problem, @lithorus. Thanks! Once your new PR is merged into the master branch, please make sure to comment on each of @KernAttila's PRs (#1281, #1282, #1283, #1284) to inform @KernAttila that the conflicts have been resolved. Include the link to your new PR in each comment. This will ensure @KernAttila is aware, and we can then cancel his PRs. @KernAttila, please note that your contributions to the OpenCue project will be credited to your GitHub account since @lithorus has merged your code into his new branch. |
@lithorus thanks for doing this, I couldn't find time to get back to those PRs recently. I'm glad it finally made it to the main branch :) I'll close those PRs. |
Hmm.. I was fairly sure that it was included. I remember doing some of the tests mentioned in the PR. Will have to double-check. |
No problem, well it seems to fail on CLA only, I'll check my history and amend the bad commits. |
Thanks @lithorus and @KernAttila ! |
Link the Issue(s) this Pull Request is related to.
#1279
#1271
Summarize your change.
This PR adds an optional
Browse
button toCueLabelLineEdit
You can enable it with
setFolderBrowsable()
orsetFileBrowsable()
This function accepts optional file filters.
Applied those features to Maya, Nuke and Blender widgets
(Do we need additional file filters for those ?)
Screenshots.
File browser with filters:
Folder Browser: