Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add build support for PIE code generation for executables #1871

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add build support for PIE code generation for executables #1871

wants to merge 6 commits into from

Commits on Sep 22, 2023

  1. Bump CMake minimum version to 3.15, allow support for PIE linker flags 

    As per TSC discussion, we will bump minimum cmake version to 3.15,
this matches OpenImageIO and ASWF template project. Strictly speaking
CMake added this in 3.14, but matching the other ASWF users was seen
as a sensible option.

For correct support of PIE objects being linked correctly we need to
trigger cmake to check for pie support see:

https://cmake.org/cmake/help/latest/module/CheckPIESupported.html
https://cmake.org/cmake/help/latest/policy/CMP0083.html

Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    8379cfa View commit details
    Browse the repository at this point in the history

  2. Support CMake option for building all executables as position indepen… 

    …dent

Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    5a4a6e5 View commit details
    Browse the repository at this point in the history

  3. Add documentation note to build instructions for PIE generation 

    Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    a0dc5f0 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Fix logic error when PIE code generation is not available 

    Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9d67a78 View commit details
    Browse the repository at this point in the history

  2. fix some minor typos in documentation. 

    Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    0f95d4c View commit details
    Browse the repository at this point in the history

  3. Change documentation to refer to CMake 3.15 requirement for building 

    Signed-off-by: Kevin Wheatley <[email protected]>
    @KevinJW
    KevinJW committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    f9685f7 View commit details
    Browse the repository at this point in the history