Adsk Contrib - Improve GLEW detection #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
Signed-off-by: Patrick Hodoul <[email protected]>
|
@michdolan Closed PR #1110 to create a new one hoping it unlocks GitHub Action. |
Merged
michdolan
reviewed
Aug 20, 2020
Signed-off-by: Patrick Hodoul <[email protected]>
doug-walker
approved these changes
Aug 20, 2020
michdolan
approved these changes
Aug 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Patrick Hodoul [email protected]
The GPU CI build investigations raise a GLEW library detection problem coming from a cmake bug. The pull request manages the cmake bug to always correctly detect the GLEWlibrary.
Refer to AcademySoftwareFoundation/aswf-docker#43 for details.
Refer to https://gitlab.kitware.com/cmake/cmake/-/issues/19662 for cmake details.
To correctly test the fix, you have to install a ASWF docker image. And I used: aswf/ci-ocio:2021.