Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: ACES 2.0 #130

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

@KelSolaar KelSolaar force-pushed the feature/aces-2.0 branch 2 times, most recently from 94ddacb to c4f7ea4 Compare August 5, 2024 19:31
@KelSolaar KelSolaar force-pushed the feature/aces-2.0 branch 7 times, most recently from c84d3e3 to 53dd1a0 Compare August 31, 2024 20:55
@KelSolaar
Copy link
Contributor Author

First artifacts are here: https://github.com/AcademySoftwareFoundation/OpenColorIO-Config-ACES/actions/runs/10648206791

I haven't checked anything yet.

@carolalynn
Copy link

Amazing Thomas - just want to note a few quick things:

CG Config:

  • We had a few more views / displays in previous versions:
    • PQ P3 1000 nit Rec. 2020 lim
    • PQ P3 1000 nit P3 lim
    • SDR Cinema

Studio config:

  • Name of look transforms seem off, the gamut compression is named "ACES2065-1"
  • Did we decide to split the D65 / D60 into two configs?

General:

  • talk about "extended" displays for Display P3 etc? Might want these in both configs.
  • will do a more detailed naming/alias check later once CIF decides on names

@KelSolaar KelSolaar force-pushed the feature/aces-2.0 branch 3 times, most recently from 1aef3a0 to 573f739 Compare September 27, 2024 23:57
@doug-walker
Copy link
Contributor

I added three of the missing display built-in transforms to your spreadsheet (only one still missing).

Looking at the color spaces, I'm noticing both "Apple Log" and "AppleLog BT2020", despite the latter not being in the spreadsheet.

@KelSolaar
Copy link
Contributor Author

I implemented support for:

  • Passing the encoding as a suffix to the DisplayColorspace name
  • Excluding the D60 views although we need to discuss how we want to name the Configs

@doug-walker
Copy link
Contributor

@KelSolaar , thanks for adding the ability to have an SDR and HDR version of DisplayP3! Here are some comments looking at the most recent Studio config artifact:

  • I like your use of the "SDR - Display" and "HDR - Display" suffixes on DisplayP3. However, I'm wondering if some people will complain that some display names indicate range and others don't. An alternative would be to leave the SDR displays as "Display" and change all the HDR displays to "HDR Display". But on the other hand, indicating the range on just those displays that have both could be considered a benefit. Minor point, but do we need the second dash, perhaps "Display P3 - HDR Display" would be sufficient?
  • If we do use the proposed "Display P3 - SDR - Display" name, we should add the previous name and "displayp3_display" aliases for backwards compatibility.
  • It looks like for all the HDR displays, we are include the SDR ACES views, to have them available for soft-proofing. So it's expected to see the SDR displays in the HDR version. However, please remove the HDR views from the SDR display.
  • This config continues to have both the D65 and D60 views (I guess the new option to remove D60 was not in effect?). However, the Display P3 views are a strange and incomplete mix of D60 and D65.
  • Both display color spaces have the same set of ACEStransformIDs. Not sure what to do here. Probably we should only include the SDR views with the SDR display, and HDR views with the HDR display. But just wondering if there would be scenarios where it's safer to have all of them?

@doug-walker
Copy link
Contributor

doug-walker commented Nov 4, 2024

I had an action-item from the last meeting to check the ACES v2 config to see if we have all the color spaces from the ACES v1.3 configs. Here are my findings:

  • For the named_transforms, "ARRI LogC3 - Curve (EI800)" is missing.
  • All scene-referred color spaces are present.
  • For the display-referred color spaces, the displays that are not included in the ACES v2 set are missing, these are: "Rec.1886 Rec.2020 - Display", "P3-D60 - Display", and "P3-DCI - Display".
  • There are a lot of aliases that are missing. I guess we should discuss whether we want to include all of them, or use this as an opportunity to prune some of the older ones.

Not sure what to do about the displays. On the one hand, they are not very relevant and I'm open to dropping them. On the other hand, I'm just wondering if anyone will complain about missing displays when moving from ACES v1 to v2.

@KelSolaar
Copy link
Contributor Author

KelSolaar commented Nov 12, 2024

Hello,

Thanks for the thorough review!

1

Minor point, but do we need the second dash, perhaps "Display P3 - HDR Display" would be sufficient?

The second dash is coming from the - Display suffix that we consistently add to all the display colourspaces. It feels a bit arbitrary to add that to Display P3 when none of the other HDR display has it. What about Display P3 SDR - Display and Display P3 HDR - Display?

2

If we do use the proposed "Display P3 - SDR - Display" name, we should add the previous name and "displayp3_display" aliases for backwards compatibility.

Yes, good catch!

3

It looks like for all the HDR displays, we are include the SDR ACES views, to have them available for soft-proofing. So it's expected to see the SDR displays in the HDR version. However, please remove the HDR views from the SDR display.

Where did you see this? The only instances I saw are occurring for Display P3 which is "expected" because we use the same builtin for both HDR and SDR. It would be much cleaner to have a dedicated Display P3 HDR builtin as suggested in previous meetings:

  • I would not need to use that new gross encoding column that we added for Display P3
  • The generator would work perfectly fine as it was intended

I'm happy to make a PR for this on the OCIO side.

4

I guess the new option to remove D60 was not in effect?

Yes, I will check what happened for Display P3, maybe the quick filterer I wrote is not "smart" enough or there are yet another problem because we introduced that special case as mentioned earlier.

5

Both display color spaces have the same set of ACEStransformIDs. Not sure what to do here.

It might be time to source this AMF data from the ACES side and stop generating it on our end.

6

For the named_transforms, "ARRI LogC3 - Curve (EI800)" is missing.

I will check, it might not even be in the spreadsheet.

7

the displays that are not included in the ACES v2 set are missing

If they are not in ACES 2.0, they cannot be in the config at the moment.

8

There are a lot of aliases that are missing.

If you have a list we could talk about it yep!

@doug-walker
Copy link
Contributor

@KelSolaar , I looked again at the alias differences I reported above and found a bug in my comparison script. The changes needed are actually very minimal. Please simply add "lin_ap1_scene" to ACEScg.

@doug-walker
Copy link
Contributor

@KelSolaar , if you would like to add the additional DisplayP3 HDR built-in, you would make a second call to registry.addBuiltin here.

Suggested name: "DISPLAY - CIE-XYZ-D65_to_DisplayP3-HDR", but I'm flexible.

@KelSolaar
Copy link
Contributor Author

OP updated with the latest config artifacts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants