-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: ACES 2.0 #130
base: main
Are you sure you want to change the base?
PR: ACES 2.0 #130
Conversation
94ddacb
to
c4f7ea4
Compare
c4f7ea4
to
9982dd2
Compare
c84d3e3
to
53dd1a0
Compare
First artifacts are here: https://github.com/AcademySoftwareFoundation/OpenColorIO-Config-ACES/actions/runs/10648206791 I haven't checked anything yet. |
Amazing Thomas - just want to note a few quick things: CG Config:
Studio config:
General:
|
53dd1a0
to
9792005
Compare
1aef3a0
to
573f739
Compare
I added three of the missing display built-in transforms to your spreadsheet (only one still missing). Looking at the color spaces, I'm noticing both "Apple Log" and "AppleLog BT2020", despite the latter not being in the spreadsheet. |
Signed-off-by: Thomas Mansencal <[email protected]>
573f739
to
0a55d32
Compare
Signed-off-by: Thomas Mansencal <[email protected]>
I implemented support for:
|
@KelSolaar , thanks for adding the ability to have an SDR and HDR version of DisplayP3! Here are some comments looking at the most recent Studio config artifact:
|
I had an action-item from the last meeting to check the ACES v2 config to see if we have all the color spaces from the ACES v1.3 configs. Here are my findings:
Not sure what to do about the displays. On the one hand, they are not very relevant and I'm open to dropping them. On the other hand, I'm just wondering if anyone will complain about missing displays when moving from ACES v1 to v2. |
Hello, Thanks for the thorough review! 1
The second dash is coming from the 2
Yes, good catch! 3
Where did you see this? The only instances I saw are occurring for Display P3 which is "expected" because we use the same builtin for both HDR and SDR. It would be much cleaner to have a dedicated Display P3 HDR builtin as suggested in previous meetings:
I'm happy to make a PR for this on the OCIO side. 4
Yes, I will check what happened for Display P3, maybe the quick filterer I wrote is not "smart" enough or there are yet another problem because we introduced that special case as mentioned earlier. 5
6
I will check, it might not even be in the spreadsheet. 7
If they are not in ACES 2.0, they cannot be in the config at the moment. 8
If you have a list we could talk about it yep! |
@KelSolaar , I looked again at the alias differences I reported above and found a bug in my comparison script. The changes needed are actually very minimal. Please simply add "lin_ap1_scene" to ACEScg. |
@KelSolaar , if you would like to add the additional DisplayP3 HDR built-in, you would make a second call to registry.addBuiltin here. Suggested name: "DISPLAY - CIE-XYZ-D65_to_DisplayP3-HDR", but I'm flexible. |
References AcademySoftwareFoundation/OpenColorIO-Config-ACES#130 Signed-off-by: Thomas Mansencal <[email protected]>
References AcademySoftwareFoundation/OpenColorIO-Config-ACES#130 Signed-off-by: Thomas Mansencal <[email protected]>
Signed-off-by: Thomas Mansencal <[email protected]>
OP updated with the latest config artifacts! |
Starting a PR for the ACES 2.0 work, I haven't even tried to build the configs but the classifying code is working, so did a solid good pass at updating the spreadsheets:
Current build artifacts can be found here:
Reference
CG
Studio