Complete pybind11 wrappings for V2, V3, V4, and add pyBindImathTest #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does three things: 1. Completes the vector class wrapping, so all previous functionality is supported, including interoperability between vector classes (i.e. V2i + V2f), and interoperability between vectors and tuples and lists (i.e. V2i(1,2) + [1,2]). 2. Adds src/pybind11/PyBindImathTest/pyBindImathTest, which is a duplicate of the original test script for the Boost-based bindings, with the not-yet-implemented features commented out for now. 3. Adds wrappings for miscellaneous functions in PyImathFun.cpp, which are needed by the vector tests. The vector class tests pass, so the pybind11 functionality is now consistent with existing Boost-based bindings. All new wrappings should un-comment out the appropriate tests and validate that they pass. Signed-off-by: Cary Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does three things:
Completes the vector class wrapping, so all previous functionality is supported, including interoperability between vector classes (i.e. V2i + V2f), and interoperability between vectors and tuples and lists (i.e. V2i(1,2) + [1,2]).
Adds src/pybind11/PyBindImathTest/pyBindImathTest, which is a duplicate of the original test script for the Boost-based bindings, with the not-yet-implemented features commented out for now.
Adds wrappings for miscellaneous functions in PyImathFun.cpp, which are needed by the vector tests.
The vector class tests pass, so the pybind11 functionality is now consistent with existing Boost-based bindings.
All new wrappings should un-comment out the appropriate tests and validate that they pass.