Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved pybind11 Euler to src/pybind11 #452

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

faizhaque
Copy link

Moved the file to the correct file location.

@cary-ilm
Copy link
Member

cary-ilm commented Nov 3, 2024

Thank you, this looks better! There are still a few missing bits that hook the new methods into the configuration.

Look at PR #440, which does the same thing for the Imath::Plane and Imath::Line objects, try to follow that pattern:

  1. Added the file to CMakeLists.txt so it gets compiled.
  2. Add the call to register_imath_euler(m) to pybindimathmodule.cpp (and the forward declaration to `PyBindImath.h')

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants