Add subscript operator optimizations, remove usage #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds routines to vec4 to match others Adds a pre-defined half type for future specialization Adds C++23 logic for known subscript values Signed-off-by: Kimball Thurston <[email protected]>
avoid dynamic subscript usage by using x, y, z, w access directly Signed-off-by: Kimball Thurston <[email protected]>
In preparation for changing subscript operators, change python bindings where appropriate which get the pointers. Signed-off-by: Kimball Thurston <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not actually changing much about the vec subscript operators at this point, other than once if consteval is available, accessing with literals / compile time constants will eliminate the dynamic array usage. However, this changes many places where Imath was using subscript operators to just access the vector elements directly, which may allow optimizers to just leave things in registers more
Part of addressing optimizations suggested in #446