Fix call to _mm_cvtps_ph in half.h #448
Conversation
|
|
_mm_cvtps_ph doesn't support _MM_FROUND_NO_EXC. On Windows, if this is compiled, you will get the following warning: `warning C4556: value of intrinsic immediate argument '8' is out of range '0 - 7'` There is no corresponding instruction, so the flag should be removed. References: https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_cvtps_ph&ig_expand=2244,2221,2220,2221,2252,2220,2221,2220,2221,2221,2107,2252,2107,2107 https://developercommunity.visualstudio.com/t/-mm-cvtps-ph-doesnt-accept-mm-fround-no-exc/1343857 Signed-off-by: John Mather <[email protected]>
|
Thanks for the fix, we're happy to accept it, although our project policy is to require signed CLA forms even for minor contributions. Would you be able to sign the form, following the NOT COVERED link above? If it's too much of a hassle, I can submit a similar fix myself. |
|
Hi Cary, I'm happy to sign the CLA - I'm just in the process of finding out who the manager is on our side so that they can give me the go-ahead. |
|
@jmather-sesi, any progress with the CLA ? We're working on making a patch release soon and we'd like to include this. |
|
Hi Cary, I've followed up and it should be approved by tomorrow. |
|
Apologies, this slipped through the cracks. We'll make a new release early in the new year. |
_mm_cvtps_ph doesn't support _MM_FROUND_NO_EXC. On Windows, if this is compiled, you will get the following warning:
warning C4556: value of intrinsic immediate argument '8' is out of range '0 - 7'There is no corresponding instruction, so the flag should be removed.
References:
https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#text=_mm_cvtps_ph&ig_expand=2244,2221,2220,2221,2252,2220,2221,2220,2221,2221,2107,2252,2107,2107
https://developercommunity.visualstudio.com/t/-mm-cvtps-ph-doesnt-accept-mm-fround-no-exc/1343857