Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/10 remove support for branches #11

Merged
merged 5 commits into from
Nov 25, 2024
Merged

Feature/10 remove support for branches #11

merged 5 commits into from
Nov 25, 2024

Conversation

miroslavpojer
Copy link
Collaborator

Release Notes:

  • Removed all code part related to branches.
  • Removed input: branch
  • Removed input: fail-on-error
  • Removed output: valid
  • When problem found action fails.

Closes #10

@miroslavpojer
#10 - Remove support for branches
5230737 
- Removed all code part related to branches.
- Removed input: branch
- Removed input: fail-on-error
- Removed output: valid
- When problem found action fails.
@miroslavpojer
- Improved unit test coverage.
35bf5aa
@miroslavpojer miroslavpojer added enhancement New feature or request breaking-change labels Nov 21, 2024
@miroslavpojer miroslavpojer self-assigned this Nov 21, 2024
MobiTikula
MobiTikula reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please react to comments.

README.md Outdated Show resolved Hide resolved
version_tag_check/version_validator.py Outdated Show resolved Hide resolved
version_tag_check/version_validator.py Outdated Show resolved Hide resolved
version_tag_check/version_validator.py Outdated Show resolved Hide resolved
MobiTikula
MobiTikula approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@miroslavpojer miroslavpojer merged commit a3f41dd into master Nov 25, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the feature/10-Remove-support-for-branches branch November 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MobiTikula MobiTikula MobiTikula approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@benedeki benedeki Awaiting requested review from benedeki benedeki is a code owner

Assignees

@miroslavpojer miroslavpojer

Labels
breaking-change enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for branches
2 participants
@miroslavpojer @MobiTikula