Skip to content

Commit e00dc51

Browse files
committed
- Fix review comments.
1 parent 995e894 commit e00dc51

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ See the default action step definition:
5959
env:
6060
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6161
with:
62-
github-repository: "{ org }/{ repo }" # ${{ github.repository }}
62+
github-repository: "{ org }/{ repo }" # e.g. ${{ github.repository }}
6363
version-tag: "v0.1.0"
6464
```
6565

version_tag_check/version_validator.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -91,17 +91,17 @@ def is_valid_increment(self) -> bool:
9191
if nv.major == latest_filtered_version.major and nv.minor == latest_filtered_version.minor:
9292
if nv.patch == latest_filtered_version.patch + 1:
9393
return True
94-
logger.error(f"New tag {nv} is not one patch higher than the latest tag {latest_filtered_version}.")
94+
logger.error("New tag %s is not one patch higher than the latest tag %s.", nv, latest_filtered_version)
9595

9696
# Check if this is a valid minor or major bump
9797
if nv.major == latest_version.major:
9898
if nv.minor == latest_version.minor + 1:
9999
if nv.patch == 0:
100100
return True
101-
logger.error(f"New tag {nv} is not a valid minor bump. Latest version: {latest_version}.")
101+
logger.error("New tag %s is not a valid minor bump. Latest version: %s.", nv, latest_version)
102102
elif nv.major == latest_version.major + 1:
103103
if nv.minor == 0 and nv.patch == 0:
104104
return True
105-
logger.error(f"New tag {nv} is not a valid major bump. Latest version: {latest_version}.")
105+
logger.error("New tag %s is not a valid major bump. Latest version: %s.", nv, latest_version)
106106

107107
return False

0 commit comments

Comments
 (0)