Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2 - Implement basic logic for Release notes located in PR body #3

Merged
merged 10 commits into from
Nov 19, 2024
Merged

#2 - Implement basic logic for Release notes located in PR body #3

merged 10 commits into from
Nov 19, 2024

Conversation

miroslavpojer
Copy link
Collaborator

Release Notes:

  • Initial commit of project files.
  • Applied black.
  • Fixed pylint warnings.
  • Created content for README.md.
  • Implemented unit tests.

Closes #2

@miroslavpojer
#2 - Implement basic logic for Release notes located in PR body
5cfb1a5 
- Initial commit of project files.
- Main code is missing.
@miroslavpojer
- Applied black.
b6448fd 
- Fixed pylint warnings.
- Created content for README.md.
@miroslavpojer
- Implemented unit tests.
dec45d1
@miroslavpojer miroslavpojer self-assigned this Nov 15, 2024
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
README.md Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
README.md Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
requirements.txt Outdated Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
tests/__init__.py Outdated Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
README.md Show resolved Hide resolved
MobiTikula
MobiTikula reviewed Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my PR review, please read the comments and react on them. Thank You! :)

MobiTikula
MobiTikula reviewed Nov 19, 2024
View reviewed changes
README.md
### `fails-on-error`
- **Description**: Whether the action should fail if an error occurs.
- **Required**: No
- **Default**: `true`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny change, please keep the same pattern, when Default is before Required.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in commit aabaa63.

MobiTikula
MobiTikula approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@miroslavpojer miroslavpojer merged commit cab7783 into master Nov 19, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the feature/2-Implement-basic-logic-for-Release-notes-located-in-PR-body branch November 19, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MobiTikula MobiTikula MobiTikula approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@benedeki benedeki Awaiting requested review from benedeki benedeki is a code owner

Assignees

@miroslavpojer miroslavpojer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement basic logic for Release notes located in PR body
2 participants
@miroslavpojer @MobiTikula