Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/50 Index page to be compatible with html projects #60

Merged
merged 67 commits into from
Nov 4, 2024
Merged

Feature/50 Index page to be compatible with html projects #60

merged 67 commits into from
Nov 4, 2024

Conversation

MobiTikula
Copy link
Collaborator

@MobiTikula MobiTikula commented Oct 30, 2024 •
edited by miroslavpojer
Loading

via issues: #50 (comment), #51 (comment).

Closes #50
Closes #51

Release Notes:

  • Index page is compatible with html projects (mdoc viewer).

@MobiTikula
Logic for having more project data for one issue half way done.
dc0e483
@MobiTikula
Logic that handles more projects attached to one repository issue. Py…
3744049 
…lint settings updated with not checking test files.
@MobiTikula
Bug fix.
5bd1fe6
@MobiTikula
Comments updated.
c2e02ff
@MobiTikula
Bug fix.
1022b33
@MobiTikula
Index page bug fix.
b161cc0
@MobiTikula
New feature for having a structured output added.
71ab3ad
@MobiTikula
Typo fix.
ea9ac2f
@MobiTikula
README.md comments implemented.
9a038a3
@MobiTikula
ActionInput comment implemented.
300fea5
@MobiTikula
ActionInput new structure implemented.
2f57dd5
@MobiTikula
Merge branch 'master' into feature/37-Add-control-&-logic-for-repo-su…
7ae8769 
…b-directories
@MobiTikula
Black tool check fix.
f1ca7ac
@MobiTikula
Private var implemented.
0d7be27
@MobiTikula
Unittest using Pytest for utils folder.
27a34c0
@MobiTikula
New way how to write a pytest tests.
266e25f
@MobiTikula
Updated README.md with unit test and test coverage section.
879ce94
@MobiTikula
Improved github test workflow check.
d6857fa
@MobiTikula
Update static_analysis_and_tests.yml
7606047
@MobiTikula
Update static_analysis_and_tests.yml
d6b6e6b
@MobiTikula
Update static_analysis_and_tests.yml
2d9f946
@MobiTikula
Update static_analysis_and_tests.yml
473f1ec
@MobiTikula
GH workflow updated.
802f2ab
@MobiTikula
Update static_analysis_and_tests.yml
b5c0dec
@MobiTikula
Check code coverage with Pytest GH workflow final touches.
28539e1
@MobiTikula
Merge remote-tracking branch 'origin/feature/34-Introduce-Unit-Tests-…
e01e553 
…and-Code-Coverage' into feature/34-Introduce-Unit-Tests-and-Code-Coverage
@MobiTikula
Implementing the comments.
cc075a3
@MobiTikula
Implementing the comments about the utils tests.
c4573e5
@MobiTikula
Comments changed.
29f59b7
@MobiTikula
New logic for testing correct query formatting.
f7d3806
@MobiTikula MobiTikula self-assigned this Oct 30, 2024
@MobiTikula MobiTikula added the enhancement New feature or request label Oct 30, 2024
@MobiTikula MobiTikula linked an issue Oct 30, 2024 that may be closed by this pull request
Improve generated overview table on index page to be compatible with mdoc project #50
Closed
@MobiTikula MobiTikula changed the base branch from master to feature/34-Introduce-Unit-Tests-Action-Inputs October 30, 2024 11:15
@MobiTikula MobiTikula added work in progress Work on this item is not yet finished (mainly intended for PRs) and removed enhancement New feature or request labels Oct 30, 2024
miroslavpojer
miroslavpojer reviewed Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • code review
  • run unit tests
  • run local
  • simulated with mdoc
    • the page detail contains " in the first part of the page (failures in generation of mdoc)
    • missing root _index file when structured output

Base automatically changed from feature/34-Introduce-Unit-Tests-Action-Inputs to master October 31, 2024 12:15
@MobiTikula MobiTikula added enhancement New feature or request and removed work in progress Work on this item is not yet finished (mainly intended for PRs) labels Oct 31, 2024
@MobiTikula MobiTikula linked an issue Oct 31, 2024 that may be closed by this pull request
Update expected structure of generate output when cps-mdoc #51
Closed
miroslavpojer
miroslavpojer reviewed Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • code review
  • local run
  • integration output to mdoc website

living_documentation_generator/generator.py Show resolved Hide resolved
@MobiTikula MobiTikula merged commit 77d7078 into master Nov 4, 2024
3 of 4 checks passed
@MobiTikula MobiTikula deleted the feature/50-Index-Page-Compatible-With-Mdoc branch November 4, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miroslavpojer miroslavpojer miroslavpojer approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

Assignees

@MobiTikula MobiTikula

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@MobiTikula @miroslavpojer