Unit tests using Pytest for github_projects.py. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavpojer
previously approved these changes
Oct 24, 2024
| @@ -185,7 +184,7 @@ def get_project_issues(self, project: GithubProject) -> list[ProjectIssue]: | |||
|
|
|||
| # Extend project issues list per every page during pagination | |||
| project_issues_raw.extend(project_issue_data) | |||
| logger.debug("Received `%s` issue records from project: %s.", len(project_issue_data), project.title) | |||
| logger.debug("Received `%i` issue/s records from project: %s.", len(project_issue_data), project.title) | |||
There was a problem hiding this comment.
Suggested change
| logger.debug("Received `%i` issue/s records from project: %s.", len(project_issue_data), project.title) | |
| logger.debug("Received `%i` issue(s) records from project: %s.", len(project_issue_data), project.title) |
| @@ -197,6 +196,6 @@ def get_project_issues(self, project: GithubProject) -> list[ProjectIssue]: | |||
| for issue in (ProjectIssue().loads(issue_json, project) for issue_json in project_issues_raw) | |||
| if issue is not None | |||
| ] | |||
| logger.debug("Loaded `%s` issues from project: %s.", len(project_issues), project.title) | |||
| logger.debug("Loaded `%i` issue/s from project: %s.", len(project_issues), project.title) | |||
There was a problem hiding this comment.
Suggested change
| logger.debug("Loaded `%i` issue/s from project: %s.", len(project_issues), project.title) | |
| logger.debug("Loaded `%i` issue(s) from project: %s.", len(project_issues), project.title) |
miroslavpojer
approved these changes
Oct 30, 2024
MobiTikula
deleted the
feature/34-Introduce-Unit-Tests-Github-Projects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement unit tests using Pytest for action inputs file.
Release Notes: