Unit tests using Pytest for action_inputs.py. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lint settings updated with not checking test files.
…and-Code-Coverage' into feature/34-Introduce-Unit-Tests-and-Code-Coverage
MobiTikula
changed the base branch from
master
to
feature/34-Introduce-Unit-Tests-Model-Folder
|
Release Notes:
|
MobiTikula
added
the
work in progress
Base automatically changed from
feature/34-Introduce-Unit-Tests-Model-Folder
to
master
October 16, 2024 09:59
…Action-Inputs' into feature/34-Introduce-Unit-Tests-Action-Inputs
MobiTikula
added
enhancement
MobiTikula
changed the title
| @@ -125,10 +125,15 @@ def validate_inputs(out_path: str) -> None: | |||
| # Check that the INPUT_OUTPUT_PATH is not a project directory | |||
| # Note: That would cause a rewriting project files | |||
| project_directories = get_all_project_directories() | |||
| if DEFAULT_OUTPUT_PATH in project_directories: | |||
| project_directories.remove(DEFAULT_OUTPUT_PATH) | |||
| default_abspath_output_path = os.path.abspath(DEFAULT_OUTPUT_PATH) | |||
There was a problem hiding this comment.
Why do you here work with constant value instead of user's input?
There was a problem hiding this comment.
I worked with constant default, because the file can be created without user knowing. I still think, it should be kept there. So first option is to check as well if there is already an user's input OR you mentioned few weeks ago, that there is no point to remove these files at all, since it will be run only once on the GH everytime.
There was a problem hiding this comment.
After the discussion, the change is fixed in commit: af039ef.
miroslavpojer
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement unit tests using pytest for action inputs file.
Release Notes: