-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/13 documentation and formatting #30
Merged
MobiTikula
merged 29 commits into
master
from
refactoring/13-Documentation-and-formatting
Sep 2, 2024
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
8e1b161
Implementing suggested bug fixes to the POC.
MobiTikula 0a0498d
Updating README.md with new section `Expected Output`.
MobiTikula 96a1a5a
Removing Todos from the project. Improving action input logic.
MobiTikula f06dc31
action.yml and README.md files updated for current state of POC.
MobiTikula be75de8
Constants handling improved to have all project constants on one plac…
MobiTikula f6802f3
First phase of pylint refactoring.
MobiTikula d678e81
Second phase of linting the project.
MobiTikula 0677c53
Third phase of linting the project.
MobiTikula 7c0f8c1
Last phase of linting the project.
MobiTikula b3e3d99
Code format checked with BLACK: The Uncompromising Code Formatter.
MobiTikula eb6b679
Adding the class docstrings documentation to the project.
MobiTikula e465f58
Adding the module docstrings documentation to the project.
MobiTikula a22f30e
Method docstring documentation added to the project.
MobiTikula c39b54b
Solving merge conflicts.
MobiTikula 0b29d27
Docstrings update for liv-generator-model.
MobiTikula 7708806
Docstrings update for liv-generator-utils.
MobiTikula d5e2d21
Docstrings update based on the new standards.
MobiTikula b9e4d68
Formating project with black tool.
MobiTikula 5db1778
Review comments implemented into POC.
MobiTikula 0bdbf9b
Updated README.md for using a Black formatting tool.
MobiTikula c807e2c
Updated README.md for using a Black formatting tool.
MobiTikula 9c49482
Updated README.md for using tools.
MobiTikula b70f0e9
Comments suggestions added.
MobiTikula 56d941e
Black workflow added.
MobiTikula a9def3f
CI black wrong commit.
MobiTikula 830ccc6
CI black workflow implemented.
MobiTikula 3cdfef6
Update static_analysis_and_tests.yml
MobiTikula fdafc07
Bug fixes.
MobiTikula 1324bc6
Merge remote-tracking branch 'origin/refactoring/13-Documentation-and…
MobiTikula File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,9 +38,31 @@ jobs: | |
echo "Success: Pylint score is above 9.5 (project score: $PYLINT_SCORE)." | ||
fi | ||
|
||
code-format-check: | ||
runs-on: ubuntu-latest | ||
name: Black Format Check | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/[email protected] | ||
|
||
- name: Set up Python | ||
uses: actions/[email protected] | ||
with: | ||
python-version: '3.11' | ||
cache: 'pip' | ||
|
||
- name: Install dependencies | ||
run: | | ||
pip install -r requirements.txt | ||
|
||
- name: Check code format with Black | ||
id: check-format | ||
run: | | ||
black --check $(git ls-files '*.py') | ||
|
||
python-tests: | ||
runs-on: ubuntu-latest | ||
name: Python tests | ||
name: Python Tests | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/[email protected] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it is here also? It's duplicated, perhaps it's enough if black step is in the job
analysis
and then you can removecode-format-check
completely - unless there is a good reason for its existence?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block of code was not supposed to be there twice. Our idea is to have black tool as separate workflow, since it has different goal than pylint. Changed in: fdafc07.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was my idea. There are two possible reasons for job failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok then, as the duplication was removed now, I'll approve as there is nothing else at the moment :) GJ!