#92 - Add support for more characters as markdown list rows

[miroslavpojer]

#92 - Add support for more characters as markdown list rows

• Implemented support for + and * characters.

#91 - Placeholder {number} does not # before Issue or PR number

• Removed # from row templates.
• Update of PR links from Markdown to GitHub format.

Closes #92
Closes #91

Release Notes:

• Implemented support for + and * characters.

[MobiTikula]

Please implement the comments I mentioned in this review.

• Please read comments, I already made about README file in big review supporting Authors last week. Suggesting fixing all the points mentioned there.

• Also I detected an extra TODO in .pylintrc, please get rid off it.

[miroslavpojer]

As Release Notes: review comment was fixed, there is needed to fix the unit tests and update workflow to to be synced with the code and look for exact string.

Unit tests fixed in commit - 8d46ba8.
Workflow check example fixed in commit - TBD.

[MobiTikula]

This should be pytest --cov=. tests/ --cov-report=html. In your version, you don't do a coverage of main script and setup.py.

[MobiTikula]

To fully complete this PR before release, please reconsider to implement these points:

• You are using new version of Release Notes generator, where you write Release Notes comment into the body of PR. But the workflow Release Notes check is outdated. You should update the workflow for this project as well.
• I don't feel your way, how to check code coverage. As I mentioned before, you use coverage as well as pylint in one workflow. All your coverage check can be done in 2 rows of code. You can get inspiration in Living Doc repo.

There are few little things catched by pylint tool, you should solve as well.

• setup.py:1:0: C0114: Missing module docstring (missing-module-docstring)
• release_notes_generator/utils/pull_reuqest_utils.py:1:0: C0114: Missing module docstring (missing-module-docstring)
• release_notes_generator/model/record.py: TODO (42, 129, 190)
• release_notes_generator/builder.py: TODO (32)
• release_notes_generator/model/record.py:50:8: W0238: Unused private member Record.__repo (unused-private-member)
• release_notes_generator/model/record.py:132:4: W0102: Dangerous default value RELEASE_NOTE_LINE_MARKS (builtins.list) as argument (dangerous-default-value)

[miroslavpojer]

To fully complete this PR before release, please reconsider to implement these points:

• You are using new version of Release Notes generator, where you write Release Notes comment into the body of PR. But the workflow Release Notes check is outdated. You should update the workflow for this project as well.
• I don't feel your way, how to check code coverage. As I mentioned before, you use coverage as well as pylint in one workflow. All your coverage check can be done in 2 rows of code. You can get inspiration in Living Doc repo.

There are few little things catched by pylint tool, you should solve as well.

• setup.py:1:0: C0114: Missing module docstring (missing-module-docstring)
• release_notes_generator/utils/pull_reuqest_utils.py:1:0: C0114: Missing module docstring (missing-module-docstring)
• release_notes_generator/model/record.py: TODO (42, 129, 190)
• release_notes_generator/builder.py: TODO (32)
• release_notes_generator/model/record.py:50:8: W0238: Unused private member Record.__repo (unused-private-member)
• release_notes_generator/model/record.py:132:4: W0102: Dangerous default value RELEASE_NOTE_LINE_MARKS (builtins.list) as argument (dangerous-default-value)

• You are using new version of Release Notes generator, where you write Release Notes comment into the body of PR. But the workflow Release Notes check is outdated. You should update the workflow for this project as well.
  • See latest commit where it was addresses.
• I don't feel your way, how to check code coverage. As I mentioned before, you use coverage as well as pylint in one workflow. All your coverage check can be done in 2 rows of code. You can get inspiration in Living Doc repo.
  • Could you create an Issue with proposal of change or with links what would you replace?
• For pylint related points I will creat a bug issue - Fix problem in output of pylint #105