Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/45 skip release notes should allow multiple entires #113

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Feature/45 skip release notes should allow multiple entires #113

merged 6 commits into from
Nov 25, 2024

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Nov 20, 2024 •
edited
Loading

Release Notes:

  • Implemented the code.
  • Update of docs.
  • Fixed unit tests.

Closes #45

@miroslavpojer miroslavpojer added enhancement New feature or request breaking change Introduces change, that is incompatible with last release labels Nov 20, 2024
@miroslavpojer miroslavpojer self-assigned this Nov 20, 2024
@miroslavpojer miroslavpojer marked this pull request as ready for review November 21, 2024 07:44
MobiTikula
MobiTikula reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please react to my comments.

README.md Outdated Show resolved Hide resolved
release_notes_generator/model/custom_chapters.py Show resolved Hide resolved
tests/release_notes/test_record_factory.py Outdated Show resolved Hide resolved
MobiTikula
MobiTikula approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@miroslavpojer miroslavpojer merged commit ad368d7 into master Nov 25, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the feature/45-skip-release-notes-should-allow-multiple-entires branch November 25, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MobiTikula MobiTikula MobiTikula approved these changes

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

@benedeki benedeki Awaiting requested review from benedeki

Assignees

@miroslavpojer miroslavpojer

Labels
breaking change Introduces change, that is incompatible with last release enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skip-release-notes should allow multiple entires
2 participants
@miroslavpojer @MobiTikula