Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#57 - Configurable regex-based Release note detection in the PR body #112

Merged
merged 5 commits into from
Nov 25, 2024
Merged

#57 - Configurable regex-based Release note detection in the PR body #112

merged 5 commits into from
Nov 25, 2024

Conversation

miroslavpojer
Copy link
Collaborator

@miroslavpojer miroslavpojer commented Nov 20, 2024 •
edited
Loading

Release Notes:

  • Release notes title can be defined by user.
  • Release notes title can be defined by regex.

Closes #57
Closes #104

@miroslavpojer
#57 - Configurable regex-based Release note detection in the PR body
1db14f8 
- Release notes title can be defined by user.
- Release notes title can be defined by regex.
@miroslavpojer miroslavpojer self-assigned this Nov 20, 2024
@miroslavpojer miroslavpojer added the enhancement New feature or request label Nov 20, 2024
MobiTikula
MobiTikula reviewed Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tiny bugs.

release_notes_generator/action_inputs.py Show resolved Hide resolved
MobiTikula
MobiTikula approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@MobiTikula MobiTikula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@miroslavpojer miroslavpojer merged commit adeae67 into master Nov 25, 2024
4 checks passed
@miroslavpojer miroslavpojer deleted the feature/57-release-notes-detection branch November 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MobiTikula MobiTikula MobiTikula approved these changes

@benedeki benedeki Awaiting requested review from benedeki

@Zejnilovic Zejnilovic Awaiting requested review from Zejnilovic Zejnilovic is a code owner

Assignees

@miroslavpojer miroslavpojer

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make RLS notes detection string customizable Configurable regex-based Release note detection in the PR body
2 participants
@miroslavpojer @MobiTikula