Feature/fix typos in readme #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename of action output methods. - Rework of get input logic to usage of constants.
|
Release notes:
|
Zejnilovic
approved these changes
Jun 20, 2024
benedeki
reviewed
Jun 20, 2024
src/filename_inspector.py
Outdated
| set_action_output('violation-count', str(violation_count)) | ||
|
|
||
| if verbose_logging: | ||
| print(f'Total violations: {violation_count}') |
There was a problem hiding this comment.
What's the difference of print and logging?
There was a problem hiding this comment.
Print output is independent of logging settings.
What level would you propose?
There was a problem hiding this comment.
That's extra weird. There are good chances, that verbose set to true will print out the same info twice.
My suggestion:
- treat
consoleas console only output, but print there even if other option is used (and adjust descripton accordingly) - if
verboseis false, print only the violations number, if true print all violations
Or use other logic. But this is IMHO wrong.
benedeki
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_instead of-._too.Also closes #6