Skip to content

JaCoCo CI check + Python QA gates.#19

Open
tmikula-dev wants to merge 7 commits intomasterfrom
feature/57-jacoco-ci-check
Open

JaCoCo CI check + Python QA gates.#19
tmikula-dev wants to merge 7 commits intomasterfrom
feature/57-jacoco-ci-check

Conversation

@tmikula-dev
Copy link
Copy Markdown
Collaborator

@tmikula-dev tmikula-dev commented Mar 20, 2026

Overview

This pull request introduces significant improvements to CI workflows, code quality enforcement, and documentation for both the Scala (bigfiles/) and Python (smallfiles/) components of the project. Additionally, license headers and ownership metadata are updated for better maintainability and compliance.

Release Notes

  • JaCoCo CI check
  • Python QA gates
  • copilot-instructions.md

Related

Closes https://github.com/absa-group/cps-qa/issues/57

@tmikula-dev tmikula-dev self-assigned this Mar 20, 2026
@tmikula-dev tmikula-dev added the enhancement New feature or request label Mar 20, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

JaCoCo Coverage Report

Metric (instruction) Coverage Threshold Status
Overall 67.76% 80.0%
Changed Files 95.98% 80.0%
Report Coverage (O/Ch) Threshold (O/Ch) Status (O/Ch)
Report: root - scala:2.12.20 67.76% / 95.98% 80.0% / 80.0% ❌/✅
File Path Coverage Threshold Status
Comparator.scala 95.98% 0.0%

Copy link
Copy Markdown

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • read
    I have written several review comments.

@@ -1,12 +1,25 @@
/*
* Copyright 2024 ABSA Group Limited
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Year?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this last time, and you said it should be year when the module was created (different for every module). So it is 2024 for this one.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I was confused because in newly added files you have 2026.

Copy link
Copy Markdown

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the years in new files and I am ready to approve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants