清理无用资源、依赖与冗余代码 - #450
Merged
Merged
Conversation
审查者指南(小型 PR 中折叠显示)审查者指南本 PR 通过删除后端废弃接口、无用工具和导入,清理前端未引用组件、资源及依赖,并调整卫星图标的根路径加载逻辑,同时更新版本登记;验证覆盖 ESLint、类型检查、前端构建、前后端测试及测试收集,其中全量 Python 测试存在一个已知的既有 telemetry 断言失败。 文件级变更
提示和命令与 Sourcery 交互
自定义使用体验访问你的控制面板以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's Guide本 PR 通过删除后端废弃接口、无用工具和导入,清理前端未引用组件、资源及依赖,并调整卫星图标的根路径加载逻辑,同时更新版本登记;验证覆盖 ESLint、类型检查、前端构建、前后端测试及测试收集,其中全量 Python 测试存在一个已知的既有 telemetry 断言失败。 File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
嘿——我已经审阅了你的更改,看起来很棒!
Sourcery 评估
已批准。
请帮助我变得更有用!请点击每条评论上的 👍 或 👎,我会利用这些反馈来改进评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Sourcery assessment
Approved.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
摘要
dev,保留重新启用的后端启动遮罩、Sentry Electron 依赖及现有版本记录。验证
yarn eslint src/composables/satellite-config.ts src/composables/satellite-config.test.ts(通过)yarn typecheck(通过)yarn test(127/127 通过)yarn vite build(通过)python -m pytest tests/models/test_config_base.py -q(23 通过)python -m pytest tests --collect-only -q(164 项收集成功)python -m pytest tests -q(159 通过、3 跳过、2 失败;临时目录冲突项在隔离目录复跑通过,另一项为本 PR 未修改路径中的 headless import 断言失败)