endeavours: attempt to add deed of patronage completion q criteria#2336
Merged
Eremeir merged 8 commits intoATTWoWAddon:masterfrom Mar 7, 2026
Merged
Conversation
…st is not eligible for item shared data?
Contributor
Author
|
sorry, i can't easily run the parser on linux to check my changes locally, i'll try and figure that out as a separate thing. i wanted to see if it was possible to tooltip "required quests" like it does with required achievements but it seems that's not possible. |
Contributor
Author
|
ok whatever, it works i'll spend some time trying to see if i can get the parser & csvcleaner compiling on linux. might also speed up ci times since you dont need to rely on windows vms too |
Eremeir
requested changes
Mar 7, 2026
.contrib/Parser/DATAS/02 - Outdoor Zones/16 Quel'Thalas/1 - Silvermoon City/Vendors.lua
Outdated
Show resolved
Hide resolved
Eremeir
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no clue how correct this is in att terms, but tl;dr
92710