pablo and ruber package #29
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29 +/- ##
=============================================
+ Coverage 94.78% 95.73% +0.95%
- Complexity 138 202 +64
=============================================
Files 26 41 +15
Lines 307 446 +139
Branches 50 59 +9
=============================================
+ Hits 291 427 +136
- Misses 5 7 +2
- Partials 11 12 +1
Continue to review full report at Codecov.
|
carledriss
reviewed
Jul 7, 2017
| /** | ||
| * method fill number digite. | ||
| */ | ||
| public void fillNumber() { |
Contributor
There was a problem hiding this comment.
@AT-03/at-03
what is wrong here?
carledriss
reviewed
Jul 7, 2017
| /** | ||
| * Created by reinaldo on 11/03/2017. | ||
| */ | ||
| public class HistoryOneBankOcr extends FileNumberBankOcr { |
Contributor
There was a problem hiding this comment.
we don't need inheritance here.
carledriss
reviewed
Jul 7, 2017
| * @return int. | ||
| */ | ||
| public int checkSumAcount(final String accountNumber) { | ||
| List<String> listaCadena = Arrays.asList(accountNumber.split("")); |
Contributor
There was a problem hiding this comment.
why are you using Spanish?
carledriss
reviewed
Jul 7, 2017
| public class Children extends Movie { | ||
| private static final int LIMIT_NEW_CHILD = 3; | ||
| private static final double PRICE = 1.5; | ||
| private static final int NAMBER_RENTAL_DAYS = 1; |
carledriss
reviewed
Jul 7, 2017
| * {@inherentDoc} | ||
| * | ||
| * @param daysRented Int with daysRented for Children movie. | ||
| */ |
Contributor
There was a problem hiding this comment.
This should be
/**
* {@inherentDoc}
*/
carledriss
reviewed
Jul 7, 2017
| */ | ||
| String generateDetail() { | ||
| StringBuilder result = new StringBuilder(); | ||
| result.append("Rental Record for " + getName() + "\n"); |
Contributor
There was a problem hiding this comment.
@AT-03/at-03
what is wrong here?
carledriss
reviewed
Jul 7, 2017
| ); | ||
|
|
||
| // when: | ||
| HistoryOneBankOcr bankOcr = new HistoryOneBankOcr(); |
carledriss
reviewed
Jul 7, 2017
|
|
||
| // when: | ||
| HistoryOneBankOcr bankOcr = new HistoryOneBankOcr(); | ||
| String actualResult = bankOcr.verificationLineNumber(insertLineFour); |
Author
carledriss
reviewed
Jul 11, 2017
| /** | ||
| * method fill number digite. | ||
| */ | ||
| private void fillNumber() { |
Contributor
There was a problem hiding this comment.
instead of doing this
please convert a constant the Map
static final
carledriss
reviewed
Jul 11, 2017
| */ | ||
| final class MultiplesOf3And5 { | ||
| private static final int NUMBERDIVISOR = 3; | ||
| private static final int NUMBERDIVISORCINCO = 5; |
Contributor
There was a problem hiding this comment.
NUMBERDIVISOR ?
NUMBERDIVISORCINCO ?
Author
|
@carledriss thanks for your observation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.