-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] New Qt UI (pyqt6) #756
Draft
Debilski
wants to merge
11
commits into
ASPP:main
Choose a base branch
from
Debilski:feature/pyqt6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #756 +/- ##
==========================================
- Coverage 85.72% 85.11% -0.62%
==========================================
Files 21 21
Lines 2354 2378 +24
==========================================
+ Hits 2018 2024 +6
- Misses 336 354 +18
|
I got the idea from a tequila bottle. I’m innocent here :) |
2427a5e
to
8eacad7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding another work-in-progress PR for a different UI toolkit. This time PyQt6. Please see below for graphics.
I am undecided if we should really push this one and completely replace our old Tk design, but I have at least brought it into a workable state now. (I think the ghosts are still a little short and need a bit of a stretch.)
The advantages of Qt would be:
Similarly to Tk:
Disadvantages:
Virtualenv Qt6
Conda Qt6 (disclaimer: I only tested the version that pip would install)
In comparison, these show the differences/problems with Tk:
Conda Tk (no anti-aliasing)
Virtualenv Tk (anti-aliasing in text but not in graphics)
macOS Tk (does anti-aliasing but look at the colour of the buttons)
Detail (Faux 3d out of nowhere – although this actually looks cool)