Fix some inconsistencies in the CLI#7
Merged
Merged
Conversation
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Ian Jamison <Ian.Jamison@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
mathias-arm
force-pushed
the
cli-consistency
branch
2 times, most recently
from
8fa98e5 to
040594c
Compare
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
mathias-arm
force-pushed
the
cli-consistency
branch
from
040594c to
8114151
Compare
CaseyHillers
approved these changes
Apr 28, 2026
Collaborator
CaseyHillers
left a comment
CaseyHillers
left a comment
There was a problem hiding this comment.
LGTM! Nice work with the cleanup and the helper functions.
mathias-arm
force-pushed
the
cli-consistency
branch
from
1dfebba to
8eb5f29
Compare
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
- Add shared validation for padded ADAC signatures and reject nonzero padding across verification backends. - Add shared validation for Ed448 ADAC public-key padding and check certificate parsing/signing. - Make Ed448 public-key conversion consistently emit canonical 60-byte ADAC encodings. - Add regression tests for padding-related changes. Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
- Define package metadata from workspace Cargo.toml. - Define common crate version in workspace Cargo.toml. - Change to 2024 edition (resulting in some cargo fmt changes). Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
mathias-arm
force-pushed
the
cli-consistency
branch
from
8eb5f29 to
44dca39
Compare
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
Signed-off-by: Mathias Brossard <mathias.brossard@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.