V1.0.0-errata updates. #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `is_valid_to_decode`: Implies at least one mix in the test vector can be decoded.
- A compliant decoder should be able to find and decode a valid mix.
- `is_valid`: Implies all mixes in the the test vector could be decoded.
- The encoder will more strictly prevent encoding certain types of reserved fields which is not aware of.
- This maintains the safety rails on the encoder which prevent it from using certain types of extension fields under normal circumstances.
- May be used to prevent other types of reserved fields in the future.
- May rename to `is_valid_to_encode` in the future.
- `test_summary.csv`: Add a column for `is_valid_to_decode`.
- The concepts are identical for test vectors with only one mix presentation (most of the test suite).
- Hence, most existing test vectors have matching `is_valid` and `is_valid_to_decode`.
- The concepts are distinguished when there is one valid mix and one invalid mix (i.e. `test_000120`, `test_000122`, `test_000129`, `test_000130`).
- Typically we want safety rails and do not want to accidentally encode strange mixes that will never be decoded.
felicialim
approved these changes
Jul 31, 2024
…ld be decoded. - `README.md`: Clarify since the spec does not determine behavior when something is invalid IAMF that a production system may still try to find a robust way to handle "should-fail" cases. - `test_000017`: Document the encoder may have a bug where it is too strict with `num_samples_to_trim_at_end`. - `test_000026`: Encoder refuses to produce it because "Output Channel Count SHALL be set to 2", but the decoder should process it anyway because "Output Channel Count can be ignored ". - `test_000119`: Encoder refuses to produce it because the codec ID is not known, but the decoder can ignore the mix related to that codec. - `test_000502`: Encoder refuses to produce it because `num_submixes` "SHALL NOT be set to 0", but the decoder can process the other mix. - Files based on AOMediaCodec/iamf-tools@468eb9b4
|
Updated to clarify that it is OK for a system to be robust / flexible and still process tests that are invalid. |
…belong in. - Mostly intended to help with bookeeping and scripts which are used to generare the test report, and decide which tests to run. - But secondarily this helps tag tests that are relevant if a private implementer wants to examine tests based on particular versions of IAMF. - The tags match any branches the test vector will be maintained in - this is useful if future bugs are fixed that require regenerating tests. - Based on AOMediaCodec/iamf-tools@a104c1cf9.
…10 spec. - Resolves both parts A and B in AOMediaCodec#119 for the test vectors. - Part A: Add missing "expandable" size field to both of the `DecoderConfigDescriptor` and `DecoderSpecificInfo`. - Part B: Flip `DecoderConfigDescriptor` `reserved` bit to 1. - Based on AOMediaCodec/iamf-tools@57324193.
jwcullen
changed the title
is_valid_to_decode from is_valid.
|
felicialim
approved these changes
Aug 14, 2024
Merged
jwcullen
force-pushed
the
add_is_valid_to_decode
branch
from
3221650
to
67499cb
Compare
Generated file based on AOMediaCodec/iamf-tools@1d2e00a
yongmin-kwon
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See extended commit description.
This helps distinguish between test vectors the encoder would typically produce (well-behaved) and ones that utilize various extensions, and fallback features, which would result in a compliant decoder ignoring some of the mixes.
For IAMF compliance the
is_valid_to_decodefield is what matters.