Support reading image using WIC on Windows #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jamaika1
reviewed
Mar 21, 2021
|
Any plans to finally add this in avifenc since for now it's not possible directly convert webp to avif with it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to use WIC API to support reading from any image formats Windows supported, including JPEG, PNG (these two are not used by us), TIFF, BMP, GIF and some others. It's also extensible so if with addon Windows is able to open it we are also able to read from it. (which means we also supports reading from WEBP, HEIF and even AVIF ourselves)
This PR only supports decoding, and only reads the first frame from an input file. In the future we may explore encoding using WIC to get rid of complicated dependency configuration of libjpeg and libpng on Windows, and also multiple-frame input support.