Skip to content

refactor(instrumentation): remove Roslyn utility dependency - #541

Draft
ANcpLua wants to merge 1 commit into
mainfrom
agent/remove-runtime-roslyn-utilities
Draft

refactor(instrumentation): remove Roslyn utility dependency#541
ANcpLua wants to merge 1 commit into
mainfrom
agent/remove-runtime-roslyn-utilities

Conversation

@ANcpLua

@ANcpLua ANcpLua commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace runtime Guard.NotNull calls with ArgumentNullException.ThrowIfNull
  • remove the ANcpLua.Roslyn.Utilities package and global using from qyl.instrumentation
  • extend the repository verification gate across collector and instrumentation runtime projects

Why

The instrumentation runtime used a Roslyn utility package for basic null guards. The BCL owns that behavior without the extra runtime dependency, and the expanded verification prevents the dependency or its extension methods from returning.

Validation

  • staged exactly the three intended files on a branch created from origin/main
  • git diff --cached --check
  • no local compilation or tests were run, per the active instruction not to compile until explicitly requested

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 16bca631-bb5b-4f8f-8640-01c5fac1dd39

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant