Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brotli update #227

Open
wants to merge 17 commits into
base: dependabot/cargo/brotli-7.0
Choose a base branch
from

Conversation

extiop
Copy link

@extiop extiop commented Nov 9, 2024

@extiop extiop closed this Nov 9, 2024
@extiop extiop deleted the dependabot/cargo/brotli-7.0 branch November 9, 2024 16:18
@extiop extiop restored the dependabot/cargo/brotli-7.0 branch November 9, 2024 16:18
@extiop extiop reopened this Nov 9, 2024
@extiop extiop added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 9, 2024
@extiop
Copy link
Author

extiop commented Nov 9, 2024

https://github.com/ANSSI-FR/MLA/actions/runs/11757955859/job/32755804089?pr=227 can't success as latest MLA release (from 2/10/23) is behind the commit introducing InnerReaderTrait in layers::traits 18fc150. Thus it is not yet published, but it does not affect other workflows, for instance tests.

@extiop extiop linked an issue Nov 11, 2024 that may be closed by this pull request
@extiop extiop added the github_actions Pull requests that update GitHub Actions code label Nov 12, 2024
@extiop extiop force-pushed the dependabot/cargo/brotli-7.0 branch 2 times, most recently from 31c9ec3 to a946bed Compare December 13, 2024 16:13
@extiop extiop force-pushed the dependabot/cargo/brotli-7.0 branch from a946bed to 3a2a2bd Compare December 13, 2024 16:28
@extiop
Copy link
Author

extiop commented Dec 16, 2024

1.83 rustc release fails cross compiling C/C++ to Rust as cc-rs does not link correctly according to the architecture cf. :

It is fixed in 1.2.3 of cc-rs. Nightly release is not yet updated to this version (cf. https://github.com/rust-lang/rust/blob/master/Cargo.lock#L408) as of today.

Hence, I pin 1.82 for the moment for msvc builds (cf. bdba30d).

@extiop extiop force-pushed the dependabot/cargo/brotli-7.0 branch 3 times, most recently from 10ce5a3 to 4c48168 Compare December 17, 2024 01:12
@extiop extiop force-pushed the dependabot/cargo/brotli-7.0 branch from 4c48168 to 59d00f7 Compare December 17, 2024 01:16
@extiop
Copy link
Author

extiop commented Dec 17, 2024

Fails like https://github.com/ANSSI-FR/MLA/actions/runs/12364423067/job/34507635501?pr=227 and https://github.com/ANSSI-FR/MLA/actions/runs/12364423067/job/34507634605?pr=227 are most likely explained by #226 and https://github.com/ANSSI-FR/MLA/blob/master/mlar/tests/integration.rs#L43. Indeed, when file3.bin from the setup() is used in test_repair_auth_unauth() integration test, the input to mlar is 10 bytes and brotli fails to read it correctly as explained in the issue. Thereby, it fails the test as unauthenticated read data is equal to authenticated read data, which is 0, failing here https://github.com/ANSSI-FR/MLA/blob/master/mlar/tests/integration.rs#L544.

Thus, the feature (unauthenticated and authenticated data from repair cf. #222) works well but fixing this side problem is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Committing Cargo.lock
1 participant