Remove unnessesary copy for OpenMP offload #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Inputs
struct,in
, is unnecessarily copied back to the host after execution of the target region.This is minor and this fix has negligible performance improvement.
I additionally added a
defaultmap(none)
clause which enforces explicit data mapping at compile time, likely reducing the chance of similar oversights in the future.I chose to map the entire struct instead of only the elements used in the target region, because it is faster in my experiments. The explanation is that copying the entire struct only initiates one HtoD memcpy call, whereas mapping each element would have initiated one for each struct element which turns out to be ~50% more expensive than copying a a few dozen extra bytes in a single memcpy call.