Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6th seminar #5

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

6th seminar #5

wants to merge 5 commits into from

Conversation

cirtuare
Copy link
Collaborator

합세 마감 이슈로...기본 구현만 해놓았습니다. 리팩 예정입니다 !!!

2024-11-29.11.58.58.mov

@cirtuare cirtuare self-assigned this Nov 29, 2024
Copy link

@sozohoy sozohoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!


// MARK: - Views
struct AppListView: View {
let apps: [AppItem] = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 모델, View를 한 파일에 정의할 필요는 없어보입니다!
  • MockData는 따로 뺴서 구현해놓을 수 있을 것 같아요 ㅎㅎ 잘 아시겠지만!

Comment on lines +123 to +134
var body: some View {
Group {
switch type {
case .download:
downloadButton
case .update:
textButton("업데이트")
case .get:
textButton("받기")
}
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Group을 사용한 이유는 무엇인가요?

Comment on lines +150 to +155
func body(content: Content) -> some View {
content
.padding(.vertical, 6)
.background(Color(.systemGray6))
.clipShape(RoundedRectangle(cornerRadius: 16))
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Modifier 구현 좋네요!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants