Skip to content

Commit

Permalink
Merge branch 'development' into regenerate_he_nets
Browse files Browse the repository at this point in the history
  • Loading branch information
zingale authored Dec 11, 2024
2 parents cf946f1 + f4ce75f commit 03b01cb
Show file tree
Hide file tree
Showing 5 changed files with 52 additions and 38 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cuda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
cd ../..
- name: Dependencies
run: .github/workflows/dependencies/dependencies_nvcc11.sh
run: .github/workflows/dependencies/dependencies_nvcc.sh 11.7

- name: compile test_react (aprox13)
run: |
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/dependencies/dependencies_hip.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ echo 'export PATH=/opt/rocm/llvm/bin:/opt/rocm/bin:/opt/rocm/profiler/bin:/opt/r

# we should not need to export HIP_PATH=/opt/rocm/hip with those installs

sudo apt-get clean
sudo apt-get update

# Ref.: https://rocmdocs.amd.com/en/latest/Installation_Guide/Installation-Guide.html#installing-development-packages-for-cross-compilation
Expand All @@ -56,7 +57,9 @@ sudo apt-get install -y --no-install-recommends \
roctracer-dev \
rocprofiler-dev \
rocrand-dev \
rocprim-dev
rocfft-dev \
rocprim-dev \
rocsparse-dev

# hiprand-dev is a new package that does not exist in old versions
sudo apt-get install -y --no-install-recommends hiprand-dev || true
Expand Down
41 changes: 41 additions & 0 deletions .github/workflows/dependencies/dependencies_nvcc.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
#!/usr/bin/env bash
#
# Copyright 2020-2022 Axel Huebl
#
# License: BSD-3-Clause-LBNL

set -eu -o pipefail

# `man apt.conf`:
# Number of retries to perform. If this is non-zero APT will retry
# failed files the given number of times.
echo 'Acquire::Retries "3";' | sudo tee /etc/apt/apt.conf.d/80-retries

sudo apt-get -qqq update
sudo apt-get install -y \
build-essential \
ca-certificates \
cmake \
g++ \
gfortran \
gnupg \
libopenmpi-dev \
openmpi-bin \
pkg-config \
wget

VERSION_DOTTED=${1-12.0} && VERSION_DASHED=$(sed 's/\./-/' <<< $VERSION_DOTTED)
curl -O https://developer.download.nvidia.com/compute/cuda/repos/ubuntu2004/x86_64/cuda-keyring_1.0-1_all.deb
sudo dpkg -i cuda-keyring_1.0-1_all.deb
sudo apt-get update
sudo apt-get install -y \
cuda-command-line-tools-$VERSION_DASHED \
cuda-compiler-$VERSION_DASHED \
cuda-cupti-dev-$VERSION_DASHED \
cuda-minimal-build-$VERSION_DASHED \
cuda-nvml-dev-$VERSION_DASHED \
cuda-nvtx-$VERSION_DASHED \
libcufft-dev-$VERSION_DASHED \
libcurand-dev-$VERSION_DASHED \
libcusparse-dev-$VERSION_DASHED
sudo ln -s cuda-$VERSION_DOTTED /usr/local/cuda
34 changes: 0 additions & 34 deletions .github/workflows/dependencies/dependencies_nvcc11.sh

This file was deleted.

8 changes: 6 additions & 2 deletions Make.Microphysics_extern
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,18 @@ ifeq ($(USE_CONDUCTIVITY),TRUE)
EXTERN_CORE += $(CONDUCTIVITY_PATH)
endif

# backwards compatibility -- remove after 25.01
ifdef Opacity_dir
OPACITY_DIR=$(Opacity_dir)
endif

ifeq ($(USE_RAD), TRUE)
ifeq ($(Opacity_dir), null)
ifeq ($(OPACITY_DIR), null)
$(error The null opacity directory has been removed, please update to rad_power_law)
endif
EXTERN_CORE += $(MICROPHYSICS_HOME)/opacity

OPAC_PATH := $(MICROPHYSICS_HOME)/opacity/$(Opacity_dir)
OPAC_PATH := $(MICROPHYSICS_HOME)/opacity/$(OPACITY_DIR)
EXTERN_CORE += $(OPAC_PATH)
endif

Expand Down

0 comments on commit 03b01cb

Please sign in to comment.