Feat/comparative graph capture changes#797
Draft
kyle-hoffmeyer wants to merge 25 commits into
Draft
Conversation
…unts mismatch AMD capture traces sometimes record extra HIP dispatch API calls (hipExtModuleLaunchKernel, hipLaunchKernel) that get consolidated during graph optimization, causing a count mismatch vs graph kernels. Previously the merge was skipped entirely for that execution root, leaving its kernels as flat children of hipGraphLaunch with no cpu_op ancestry. Adds _align_capture_to_graph which scans forward through capture dispatch events to match each graph kernel by name, discarding any unmatched extras. verify_subtree_events now returns a (success, aligned_capture_events) tuple so the caller can proceed with the aligned subset when counts differ but names align. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
…aph_capture_changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template