Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove forbidden characters & add encoding reversal scripts for … #1084

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

raghuvar-vijay
Copy link
Collaborator

…htcondor and slurm

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.18%. Comparing base (81f7f5c) to head (62e05e7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   63.12%   63.18%   +0.06%     
==========================================
  Files          55       55              
  Lines        7189     7171      -18     
  Branches       64       66       +2     
==========================================
- Hits         4538     4531       -7     
+ Misses       2651     2640      -11     
Components Coverage Δ
apel_plugin 78.54% <ø> (ø)
auditor 65.36% <100.00%> (-0.19%) ⬇️
auditor_client 92.14% <ø> (ø)
slurm_collector 71.96% <40.00%> (+0.18%) ⬆️
slurm_epilog_collector 0.00% <0.00%> (ø)
htcondor_collector ∅ <ø> (∅)
priority_plugin 36.31% <ø> (ø)

@raghuvar-vijay raghuvar-vijay force-pushed the valid_names branch 4 times, most recently from 7efd5a9 to 5c19399 Compare December 15, 2024 16:04
@raghuvar-vijay raghuvar-vijay marked this pull request as ready for review December 16, 2024 08:26
Copy link
Member

@dirksammel dirksammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't remove the encoding parts of the HTCondor collector?

media/website/content/migration.md Outdated Show resolved Hide resolved
@raghuvar-vijay raghuvar-vijay force-pushed the valid_names branch 2 times, most recently from 933f31f to 1d20723 Compare January 15, 2025 11:10
media/website/content/migration.md Outdated Show resolved Hide resolved
@raghuvar-vijay raghuvar-vijay force-pushed the valid_names branch 4 times, most recently from f00d7a7 to 24f6f4c Compare January 20, 2025 00:28
auditor/scripts/revert_encoding/test_script.py Outdated Show resolved Hide resolved
media/website/content/migration.md Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open issues as discussed:

  • test_main is not called
  • change quote("record1/") to quote("record1/", safe="") etc.
  • change %20 to %2F

Unverified

No user is associated with the committer email.
…htcondor and slurm
…ncodings.py & remove encoding of records for HTCondor
…python script for reversal of both slurm and htcondor encodings
@raghuvar-vijay raghuvar-vijay force-pushed the valid_names branch 3 times, most recently from 110b070 to c04f1be Compare January 22, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants