-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove forbidden characters & add encoding reversal scripts for … #1084
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
==========================================
+ Coverage 63.12% 63.18% +0.06%
==========================================
Files 55 55
Lines 7189 7171 -18
Branches 64 66 +2
==========================================
- Hits 4538 4531 -7
+ Misses 2651 2640 -11
|
7efd5a9
to
5c19399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't remove the encoding parts of the HTCondor collector?
auditor/scripts/htcondor_revert_encoding/htcondor_revert_encodings.py
Outdated
Show resolved
Hide resolved
933f31f
to
1d20723
Compare
f00d7a7
to
24f6f4c
Compare
01943e8
to
9263197
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open issues as discussed:
- test_main is not called
- change quote("record1/") to quote("record1/", safe="") etc.
- change %20 to %2F
…htcondor and slurm
…ncodings.py & remove encoding of records for HTCondor
…python script for reversal of both slurm and htcondor encodings
110b070
to
c04f1be
Compare
…ote for encoding '/'
c04f1be
to
62e05e7
Compare
…htcondor and slurm