Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update permissions on alloy config files #25

Merged
merged 8 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .github/workflows/flake.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,22 +10,22 @@ env:
CACHIX_BINARY_CACHE: altf4llc-os

jobs:
check:
test:
runs-on: ubuntu-latest
strategy:
matrix:
profile:
- alloy
steps:
- uses: cachix/install-nix-action@v27
with:
enable_kvm: true
- uses: cachix/cachix-action@v15
with:
authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
name: ${{ env.CACHIX_BINARY_CACHE }}
- uses: actions/checkout@v4
- run: nix develop -c just check
- run: nix develop -c just test "${{ matrix.profile }}"

build:
needs:
- check
runs-on: ubuntu-latest
permissions:
contents: read
Expand All @@ -38,9 +38,6 @@ jobs:
- actions-runner
steps:
- uses: cachix/install-nix-action@v27
with:
enable_kvm: true

- uses: cachix/cachix-action@v15
with:
authToken: ${{ secrets.CACHIX_AUTH_TOKEN }}
Expand Down
2 changes: 2 additions & 0 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
buildInputs = [awscli2 just];
};

checks = import ./modules/tests { inherit pkgs; };

formatter = pkgs.alejandra;

packages = import ./nix/images.nix { inherit system inputs; };
Expand Down
3 changes: 3 additions & 0 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@ build profile:

publish-ami profile:
bash ./ci-build-publish.sh "{{ami_bucket}}" "{{profile}}"

test profile arch='x86_64-linux':
just build 'checks.{{arch}}.{{profile}}'
13 changes: 3 additions & 10 deletions modules/mixins/alloy-forwarder/config.alloy
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,12 @@ loki.source.api "receive" {
listen_address = "0.0.0.0"
listen_port = 3100
}
forward_to = [
grafana_cloud.stack.receivers.logs,
]
forward_to = [grafana_cloud.stack.receivers.logs]
}

loki.source.journal "read" {
forward_to = [
grafana_cloud.stack.receivers.logs,
]
relabel_rules = concat(
loki.relabel.journal.rules,
loki.relabel.instance.rules,
)
forward_to = [grafana_cloud.stack.receivers.logs]
relabel_rules = loki.relabel.omnibus.rules
labels = {
"job" = "integrations/node_exporter",
}
Expand Down
9 changes: 2 additions & 7 deletions modules/mixins/alloy/base.alloy
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,14 @@ local.file "hostname" {
filename = "/etc/hostname"
}

// Set hostname from /etc
loki.relabel "instance" {
// Loki journal relabeller
loki.relabel "omnibus" {
forward_to = []

rule {
target_label = "instance"
replacement = local.file.hostname.content
}
}

// Loki journal relabeller
loki.relabel "journal" {
forward_to = []

rule {
source_labels = ["__journal__systemd_unit"]
Expand Down
18 changes: 9 additions & 9 deletions modules/mixins/alloy/config.alloy
Original file line number Diff line number Diff line change
Expand Up @@ -32,30 +32,30 @@ loki.relabel "journal" {
forward_to = []

rule {
source_labels = ["__journal__systemd_unit"]
target_label = "unit"
target_label = "instance"
replacement = local.file.hostname.content
}

rule {
source_labels = ["__journal_container_name"]
target_label = "container_name"
source_labels = ["__journal__systemd_unit"]
target_label = "unit"
}

rule {
source_labels = ["__journal_image_name"]
target_label = "container_image"
source_labels = ["__journal__boot_id"]
target_label = "boot_id"
}

rule {
source_labels = ["__journal_container_id"]
target_label = "container_id"
source_labels = ["__journal__transport"]
target_label = "transport"
}
}

// Fetch journal entries
loki.source.journal "journal" {
forward_to = [otelcol.receiver.loki.default.receiver]
relabel_rules = loki.relabel.journal.rules
relabel_rules = loki.relabel.omnibus.rules
labels = {component = "loki.source.journal"}
}

Expand Down
14 changes: 2 additions & 12 deletions modules/mixins/alloy/default.nix
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
{ ... }: {
environment.etc."alloy/config.alloy" = {
source = ./config.alloy;
mode = "0440";
user = "root";
};

environment.etc."alloy/base.alloy" = {
source = ./base.alloy;
mode = "0440";
user = "root";
};

environment.etc."alloy/config.alloy".source = ./config.alloy;
environment.etc."alloy/base.alloy".source = ./base.alloy;
services.alloy.enable = true;
}
6 changes: 1 addition & 5 deletions modules/mixins/docker/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,5 @@
virtualisation.oci-containers.backend = "docker";

# Monitoring
environment.etc."alloy/docker.alloy" = {
source = ./config.alloy;
mode = "0440";
user = "root";
};
environment.etc."alloy/docker.alloy".source = ./config.alloy;
}
5 changes: 1 addition & 4 deletions modules/mixins/ecs-agent/config.alloy
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
prometheus.scrape "ecs_agent" {
targets = [
{"__address__" = "127.0.0.1:51680", instance = env("HOSTNAME")},
]

targets = [{"__address__" = "127.0.0.1:51680"}]
forward_to = [prometheus.relabel.instance.receiver]
scrape_interval = "30s"
}
Expand Down
6 changes: 1 addition & 5 deletions modules/mixins/ecs-agent/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,5 @@
};

# Monitoring
environment.etc."alloy/ecs-agent.alloy" = {
source = ./config.alloy;
mode = "0440";
user = "root";
};
environment.etc."alloy/ecs-agent.alloy".source = ./config.alloy;
}
15 changes: 15 additions & 0 deletions modules/tests/alloy/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{ pkgs, ... }:
pkgs.testers.runNixOSTest {
name = "alloy-test";

nodes.machine = { ... }: {
networking.firewall.allowedTCPPorts = [ 12345 ];
imports = [ ../../mixins/alloy ];
};

testScript = ''
machine.wait_for_unit("alloy.service", timeout=10)
machine.wait_for_open_port(12345, timeout=10)
machine.succeed("curl http://localhost:12345 | grep -o \"Grafana Alloy\"")
'';
}
4 changes: 4 additions & 0 deletions modules/tests/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{ pkgs, ... }:
{
alloy = pkgs.callPackage ./alloy/default.nix { };
}