Replaced append(Period) with add_interval(kwargs) #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
BSchilperoort
requested review from
Peter9192 and
geek-yang
and removed request for
Peter9192
geek-yang
reviewed
Nov 22, 2022
There was a problem hiding this comment.
Looks really nice to me. I checked the codes and the notebook. The tasks are clearly defined and the implementations are quite clean. Only got one minor comment, which concerns the test. I would wait for the feedback from @Peter9192, before this PR can be merged. Nice work!
Comment on lines
+175
to
+183
| while True: | ||
| prev_end_calendar = self._get_anchor(proto_year - 1 - skip_years) | ||
| for target in self._targets: | ||
| prev_end_calendar += target.gap | ||
| prev_end_calendar += target.length | ||
| if prev_end_calendar > start_calendar: | ||
| skip_years += 1 | ||
| else: | ||
| break |
| interval("2020-12-01", "2021-01-01", closed="left")] | ||
| ) | ||
| assert np.array_equal(cal.flat, expected) | ||
|
|
There was a problem hiding this comment.
Would be nice to have one more test for the allow_overlap case.
|
closes #134 ? |
|
Closed
Yes! I mistyped that. |
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will tackle Peter's comments about the Period classes:
calendar.add_target_period(...)andadd_precursor_period? I found myself doingcalendar.append(PrecursorPeriod("1d")), which I think is a sign of suboptimal APIadd_target,add_target_period,add_target_interval,add_period(target=True),add_interval(target=True), oradd_block(target=True)? What's the difference between a precursor and targetperiod?I would love to be able to add a period by specifying a length and end day, e.g. if I want to issue a forecast by the end of may, I want to start appending precursors from 31 may backwards.See Specifying start/end day and length of a target/precursor period lilio#3Changes:
calendar.add_interval("target", "10d", gap="2d')skip_nyearscalendar.add_interval("target", "2M")mypyversion is pinned, see Pinningmypyversion #134.