Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Llama 3.1 RoPE implementation #929

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Llama 3.1 RoPE implementation #929

merged 1 commit into from
Oct 3, 2024

Conversation

gagika
Copy link
Collaborator

@gagika gagika commented Oct 1, 2024

@gagika gagika requested a review from gobbleturk as a code owner October 1, 2024 19:57
@gagika gagika requested a review from khatwanimohit October 1, 2024 19:59
khatwanimohit
khatwanimohit approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@khatwanimohit khatwanimohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Gagik

gobbleturk
gobbleturk approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@gobbleturk gobbleturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for adding a test Gagik!

@gagika gagika force-pushed the llama_rope branch 3 times, most recently from 7552e74 to 41ff7cb Compare October 3, 2024 00:12
@gagika gagika requested a review from vipannalla as a code owner October 3, 2024 05:20
@gagika gagika requested a review from khatwanimohit October 3, 2024 05:29
@gagika gagika assigned khatwanimohit and unassigned gobbleturk Oct 3, 2024
@gagika gagika force-pushed the llama_rope branch 2 times, most recently from b29e0dc to b6a09b8 Compare October 3, 2024 18:13
@copybara-service copybara-service bot merged commit c120aaf into main Oct 3, 2024
14 checks passed
@copybara-service copybara-service bot deleted the llama_rope branch October 3, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gobbleturk gobbleturk gobbleturk approved these changes

@khatwanimohit khatwanimohit khatwanimohit approved these changes

@vipannalla vipannalla Awaiting requested review from vipannalla vipannalla is a code owner

Assignees

@khatwanimohit khatwanimohit

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gagika @gobbleturk @khatwanimohit