Fix MoE related tests #1064
Merged
Fix MoE related tests #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RissyRan
force-pushed
the
fix_8x22_ckpt
branch
4 times, most recently
from
06e75bb
to
ac86c96
Compare
RissyRan
force-pushed
the
fix_8x22_ckpt
branch
from
ac86c96
to
ea7bd6d
Compare
RissyRan
requested review from
gobbleturk,
khatwanimohit,
bvandermoon and
vipannalla
as code owners
gobbleturk
approved these changes
Nov 26, 2024
|
|
||
| # Test whether the forward pass logits match the golden logits - megablox implementation | ||
| python3 MaxText/tests/forward_pass_logit_checker.py MaxText/configs/base.yml base_output_directory=${BASE_OUTPUT_PATH} load_parameters_path=${SCANNED_CHECKPOINT} run_name=megablox_forward_pass_test per_device_batch_size=8 model_name=mixtral-8x7b tokenizer_path=assets/tokenizer.mistral-v1 ici_fsdp_parallelism=64 max_prefill_predict_length=11 max_target_length=11 dataset_type=synthetic dtype=bfloat16 weight_dtype=bfloat16 --atol=4 --rtol=1 --token_size=4 | ||
| # TODO(ranran): investigate the root cause of the excessive tolerance |
There was a problem hiding this comment.
In b/380148614 the root cause of excessive tolerance?
There was a problem hiding this comment.
I am not sure actually. Using current ckpt, matmul implementation could match the logits well. Something seems off, as we could match logits a while back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/379315309
Tests
** 8x7b decoding: link
** 8x7b forward_pass_logit_checker: link, link
Checklist
Before submitting this PR, please make sure (put X in square brackets):