Skip to content

Commit

Permalink
Changes
Browse files Browse the repository at this point in the history
  • Loading branch information
SujeethJinesh committed Jan 23, 2025
1 parent 7075733 commit 2f8124f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
2 changes: 1 addition & 1 deletion benchmarks/maxtext_trillium_model_configs.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def _add_to_model_dictionary(model_dictionary: dict[str, MaxTextModel], maxtext_
"dataset_type": "synthetic",
"reuse_example_batch": 1,
"enable_checkpointing": False,
"profiler": "xplane",
# "profiler": "xplane",

# Additional tuning params for pathways long running test.
"enable_checkpointing": True,
Expand Down
16 changes: 7 additions & 9 deletions benchmarks/pw_remote_python_recipe.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
"""
Copyright 2025 Google LLC
"""Copyright 2025 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -57,7 +56,7 @@ def main() -> int:
# Delete workloads starting with the first 5 characters of the user's name.
first_five_chars = user[:5]
delete_command = (
f"python3 xpk/xpk.py workload delete "
"python3 xpk/xpk.py workload delete "
f" --project={cluster_config.project} --cluster={cluster_config.cluster_name}"
f" --filter-by-job={first_five_chars} --zone={cluster_config.zone}"
)
Expand All @@ -77,9 +76,7 @@ def main() -> int:
"server:latest"
)
runner = f"gcr.io/{cluster_config.project}/{user}_latest:latest"
remote_python_image = (
f"gcr.io/{cluster_config.project}/{user}/remote_python_sidecar_latest:latest"
)
remote_python_image = f"gcr.io/{cluster_config.project}/{user}/remote_python_sidecar_latest:latest"

pathways_config = mxr.PathwaysConfig(
server_image=server_image,
Expand All @@ -91,9 +88,9 @@ def main() -> int:
base_output_directory = f"gs://{user}-{region}/{user}"

list_of_models = [
# model_configs.llama2_70b_4096_pw_long_run_v5e,
# model_configs.llama2_7b_4096_pw,
model_configs.default_basic_1_pw_v5e,
# model_configs.llama2_70b_4096_pw_long_run_v5e,
# model_configs.llama2_7b_4096_pw,
model_configs.default_basic_1_pw_v5e,
]

xpk_workload_cmds = []
Expand All @@ -119,6 +116,7 @@ def main() -> int:
base_docker_image="",
pathways_config=pathways_config,
xpk_path="xpk",
num_steps=1000000,
)
command, name = mxr.generate_xpk_workload_cmd(
cluster_config=cluster_config, wl_config=wl_config
Expand Down

0 comments on commit 2f8124f

Please sign in to comment.