Add collectives configurations for different slice size #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hylin2002
force-pushed
the
add-collectives-config
branch
from
e9ec284 to
8231fdc
Compare
hylin2002
force-pushed
the
add-collectives-config
branch
from
a9815ad to
e8526fb
Compare
Collaborator
|
Discussed offline with @rahul-anand @hylin2002. The code change is reverted, and the yaml files are split into one for each op. |
chishuen
approved these changes
Jan 21, 2026
Collaborator
|
@hylin2002 Names are still confusing as it's not obvious if they are 1D, 2D or 3D all gather etc? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces configurations for various Ironwood topologies (ranging from
2x2x1to4x4x8).Key Changes
all-gather,psum(all-reduce), andall-to-all) for multiple topologies inIronwood/configs/collectives/.