tests(processing): Update regression test targets to include dna width #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests using [`pytest-regtest-2.3.2`](https://pypi.org/project/pytest-regtest/#history) are [failing on OSX](https://github.com/AFM-SPM/TopoStats/actions/runs/11780199328/job/32810287345?pr=988) pegging version to `pytest-regtest==2.3.1` to see if this resolves the issue.
As [suggested](#996 (comment)) by @SylviaWhittle we could all do with an _aide memoire_ when making Pull Requests that we have covered everything we should. This Pull Request therefore introduces just such a template to aid contributors in making sure we have covered everything. --- - [ ] Existing tests pass. **N/A** no changes to code base introduced. - [ ] Documentation has been updated and builds. **N/A** no changes to code base introduced. - [x] Pre-commit checks pass. - [ ] New functions/methods have typehints and docstrings. **N/A** no changes to code base introduced. - [ ] New functions/methods have tests which check the intended behaviour is correct. **N/A** no changes to code base introduced.
Co-authored-by: Sylvia Whittle <[email protected]>
…h and improved docstring
Splits `test_trace_image_disordered` into two tests, the original compares dictionaries, the newer (suffixed with `_dataframes`) compares the dataframes/csv files that are produced, of which there are two and one needed updating to include the `grain_width_mean` column that #999 introduces.
Two final tests needed updating to account for new `grain_width_mean` columns. Also required rebasing onto `main` and `ns-rse/994-unpin-topoly` so the changes look larger than they might.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits
test_trace_image_disorderedinto two tests, the original compares dictionaries, the newer (suffixed with_dataframes) compares the dataframes/csv files that are produced, of which there are two and one needed updating toinclude the
grain_width_meancolumn that #999 introduces.# TopoStats Pull RequestsBefore submitting a Pull Request please check the following.
configuration.md,usage.md, and relevant processing sections underadvanced.md. [Bug]: docs/data_dictionary.md does not reflect current output #1001Tests to be written in due course, this just gets the current changes passing the existing tests.Optional
topostats/default_config.yamlIf adding options to
topostats/default_config.yamlplease ensure.There is a comment adjacent to the option explaining what it is and the valid values.N/AA check is made inN/Atopostats/validation.pyto ensure entries are valid.Add the option to the relevant sub-parser inN/Atopostats/entry_point.py.…h and improved docstring