Skip to content
This repository has been archived by the owner on Oct 25, 2023. It is now read-only.

adjusted regex for matching external stack errors when SLS_DEBUG is set #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MHekert
Copy link

@MHekert MHekert commented May 19, 2021

What did you implement:

When running sls deploy with SLS_DEBUG=* errors messages have additional text and are not correctly detected by current regex. e.g

when run sls deploy without SLS_DEBUG=* error message is following:

Stack with id STACK_NAME does not exist

and when SLS_DEBUG=* is set it has following format:

ValidationError: Stack with id STACK_NAME does not exist\nSTACK_TRACE

How did you implement it:

I removed requirement for matching a beginning or ending of string and added some extra text to prevent false positive matching.

How can we verify it:

Set externalStack to true

custom:
  alerts:
    externalStack: true
    stages:
      - prod
      - test
      - dev

Run sls deploy with and without SLS_DEBUG=* set for stage present in the list and for stage not present in the list.

@MHekert MHekert force-pushed the fix/external-stack-sls-debug branch 2 times, most recently from 8f8e0a4 to 0e5c4c4 Compare October 18, 2022 15:55
@MHekert MHekert force-pushed the fix/external-stack-sls-debug branch from 2145678 to 512a6be Compare October 18, 2022 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant